Skip to content

checkpoints do not go to default_root_dir #20725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
turbotimon opened this issue Apr 17, 2025 · 0 comments
Open

checkpoints do not go to default_root_dir #20725

turbotimon opened this issue Apr 17, 2025 · 0 comments
Labels
docs Documentation related needs triage Waiting to be triaged by maintainers

Comments

@turbotimon
Copy link

turbotimon commented Apr 17, 2025

📚 Documentation

The documentation about check pointing claims:

To change the checkpoint path use the default_root_dir argument:
# saves checkpoints to 'some/path/' at every epoch end
trainer = Trainer(default_root_dir="some/path/")

However, if a logger is configured, the checkpoints go magically to the path of the logger and not to default_root_dir:

trainer = L.Trainer(
  max_epochs=EPOCHS,
  logger=CSVLogger("save_dir", "exp_name"),
  default_root_dir="default_root_dir"
)
trainer.fit(...)

Image

It's even more magic when you add several loggers (seems to take the path of the first logger)

I'm missing such thinks in the documentation...

cc @lantiga @Borda

@turbotimon turbotimon added docs Documentation related needs triage Waiting to be triaged by maintainers labels Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related needs triage Waiting to be triaged by maintainers
Projects
None yet
Development

No branches or pull requests

1 participant