Skip to content

Save checkpoint version dirs as version_003 so that they sort lexicographically #20799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Taylor-C-Reese opened this issue May 6, 2025 · 0 comments
Open

Save checkpoint version dirs as version_003 so that they sort lexicographically #20799

Taylor-C-Reese opened this issue May 6, 2025 · 0 comments
Labels
feature Is an improvement or enhancement needs triage Waiting to be triaged by maintainers

Comments

@Taylor-C-Reese
Copy link

Taylor-C-Reese commented May 6, 2025 •
edited by github-actions bot
Loading

Description & Motivation

Lightning saves checkpoint version dirs as version_3, version_21, etc. The problem with this is that when you do a listing, version_21 is between version_2 and version_3, making it easy to miss.

A simple solution, which is commonly used for these situations, is to name them version_002, version_003,... version_021, which solves the problem completely.

Note: If there's interest for this, this seems like a great first issue, and I'd be happy to write the patch.

Pitch

No response

Alternatives

No response

Additional context

No response

cc @lantiga @Borda
@Taylor-C-Reese Taylor-C-Reese added feature Is an improvement or enhancement needs triage Waiting to be triaged by maintainers labels May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Is an improvement or enhancement needs triage Waiting to be triaged by maintainers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Taylor-C-Reese