Skip to content

[Calendar]: Various issues with latest calendar #11011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
amdev138 opened this issue Mar 4, 2025 · 7 comments · Fixed by #11468 · May be fixed by #11167
Closed
1 task done

[Calendar]: Various issues with latest calendar #11011

amdev138 opened this issue Mar 4, 2025 · 7 comments · Fixed by #11468 · May be fixed by #11167
Assignees
@tsanislavgatev @didip1000
Labels
bug This issue is a bug in the code feature request Medium Prio released SAP SF TOPIC B
Milestone
2.11.0

Comments

@amdev138
Copy link

amdev138 commented Mar 4, 2025 •
edited
Loading

Bug Description

Hi team, we upgraded our project to the latest webcomponent version and found a few issues with the calendar view. All of these issues can be seen on the component playground. https://sap.github.io/ui5-webcomponents/components/Calendar/

  1. In year picker, there is no year range in the header. Please see:
Image
  1. In year picker, when there is a secondary calendar, the year range below the month is suppose to be a label (gray) color. You can compare to the month picker which has the correct color distinguishing.
Image

Image

You may also compare with the openui5, https://sapui5.hana.ondemand.com/#/entity/sap.ui.unified.Calendar/sample/sap.ui.unified.sample.CalendarCalendarType.

thanks!
Allen

Affected Component

Calendar

Expected Behaviour

Expected behavior is outlined in the description of the ticket.

Isolated Example

No response

Steps to Reproduce

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

main

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

SF

Declaration

  • I’m not disclosing any internal or sensitive information.
@amdev138 amdev138 added the bug This issue is a bug in the code label Mar 4, 2025
@Todor-ads Todor-ads self-assigned this Mar 5, 2025
@Todor-ads
Copy link
Member

Hello @SAP/ui5-webcomponents-topic-b ,

could you please check this issue?

Thanks,
Todor

@Todor-ads Todor-ads removed their assignment Mar 5, 2025
@didip1000 didip1000 self-assigned this Mar 5, 2025
@didip1000 didip1000 mentioned this issue Mar 24, 2025
Draft
@DMihaylova
Copy link

Hi @amdev138,

We're working on introducing year range view and we're in a review phase.
As part of that change you'll have both mentioned points resolved :)
Currently it's unclear whether the change will take place in version 2.10 or 2.11.

Regards,
Diana

@DMihaylova DMihaylova moved this from New to In Progress in Planning - Topic B Apr 22, 2025
@amdev138
Copy link
Author

Hi @DMihaylova ,

Thanks for you work on this ticket. Btw, this is not a feature request but rather a regression. In v1 of ui5-webcomponents it had a year picker header. Please see:

Image

Image

The above screenshots are with v1.23.1

Thanks,
Allen

@DMihaylova
Copy link

Hi @amdev138,

Apologies for the confusion :)

I added also the "feature request" label because in the past we only had the label for the year range, but not the year range view itself, which is the feature we now introduce. And having only the label without being clickable was something that was not wanted from design's side. That's why the label was removed.
And I removed it to the Planning board because both your points in this issue will be addressed with the change with the new implementation.

Regards,
Diana

@amdev138
Copy link
Author

@DMihaylova , thanks for the clarification

@DMihaylova DMihaylova added this to the 2.11.0 milestone Apr 28, 2025
@didip1000 didip1000 mentioned this issue Apr 30, 2025
Closed
@tsanislavgatev tsanislavgatev self-assigned this May 7, 2025
@tsanislavgatev tsanislavgatev mentioned this issue May 7, 2025
Merged
tsanislavgatev added a commit that referenced this issue May 7, 2025
@tsanislavgatev
fix(ui5-calendar): show year range text in year view (#11468)
3a56fd3 
The text for year range when in YearPicker was previously removed until we have the year range picker as a part of the Calendar.
We are now bringing the text back, so we can show the current year range.
Before:
image

Now:
image

fixes: #11011
@github-project-automation github-project-automation bot moved this from In Progress to Completed in Planning - Topic B May 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2025

This issue has been closed. To reopen, just leave a comment!

@tsanislavgatev tsanislavgatev mentioned this issue May 8, 2025
Merged
tsanislavgatev added a commit that referenced this issue May 8, 2025
@tsanislavgatev
fix(ui5-calendar): add style to secondary type (#11478)
30d78b8 
The secondary calendar text was not in gray before:
image

It now is:
image

related to: #11011
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This issue has been resolved in version v2.11.0-rc.0 🎉

The release is available on v2.11.0-rc.0

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsanislavgatev tsanislavgatev

@didip1000 didip1000

Labels
bug This issue is a bug in the code feature request Medium Prio released SAP SF TOPIC B
Projects
Planning - Topic B
Status: Completed
Milestone
2.11.0
7 participants
@petyabegovska @tsanislavgatev @DMihaylova @Todor-ads @didip1000 @ui5-webcomponents-bot @amdev138