Skip to content

[🚀 Feature]: Rewrite Atoms in TypeScript #15596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
titusfortner opened this issue Apr 8, 2025 · 1 comment
Open

[🚀 Feature]: Rewrite Atoms in TypeScript #15596

titusfortner opened this issue Apr 8, 2025 · 1 comment
Labels
B-atoms JavaScript chunks generated by Google closure I-enhancement Something could be better

Comments

@titusfortner
Copy link
Member

titusfortner commented Apr 8, 2025

Description

We've discussed this idea for years.

At this point we know that Closure is not going to play nicely with Bazel 9, and we really need to update this code to use Typescript.

Have you considered any alternatives or workarounds?

No response

@titusfortner titusfortner added the I-enhancement Something could be better label Apr 8, 2025
@github-actions github-actions bot added the B-atoms JavaScript chunks generated by Google closure label Apr 8, 2025
@joerg1985
Copy link
Member

joerg1985 commented Apr 9, 2025

Is this the right time to ask for improvements to the current atoms?

e.g. a element with width 0px is considered as displayed as soon as there is a text node inside, there is no check for the content of this text node, so a   will make the element "visible".

I could provide an example html of this if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-atoms JavaScript chunks generated by Google closure I-enhancement Something could be better
Projects
None yet
Development

No branches or pull requests

2 participants