Skip to content

caller_sites is not reliable #3722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
psifertex opened this issue Dec 7, 2022 · 0 comments · May be fixed by #6475
Open

caller_sites is not reliable #3722

psifertex opened this issue Dec 7, 2022 · 0 comments · May be fixed by #6475
Labels
Component: API Issue needs changes to the API Effort: Trivial Issue should take < 1 day Impact: Medium Issue is impactful with a bad, or no, workaround Type: Enhancement Issue is a small enhancement to existing functionality
Milestone
Future

Comments

@psifertex
Copy link
Member

It's possible for caller_sites to return something that is NOT a call when accessing the IL of the returned code refs.

This should be fixed by adding a small amount of logic in:

https://github.com/Vector35/binaryninja-api/blob/dev/python/function.py#L3185-L3194

that verifies the LLIL is indeed a call
@plafosse plafosse added Type: Enhancement Issue is a small enhancement to existing functionality Impact: Medium Issue is impactful with a bad, or no, workaround Effort: Trivial Issue should take < 1 day labels Jan 10, 2023
@fuzyll fuzyll added the Component: API Issue needs changes to the API label May 17, 2023
@xusheng6 xusheng6 mentioned this issue Nov 29, 2024
Open
3 tasks
@SmoothHacker SmoothHacker linked a pull request Mar 10, 2025 that will close this issue
Open
@plafosse plafosse mentioned this issue Mar 11, 2025
Closed
@fuzyll fuzyll added this to the Future milestone May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: API Issue needs changes to the API Effort: Trivial Issue should take < 1 day Impact: Medium Issue is impactful with a bad, or no, workaround Type: Enhancement Issue is a small enhancement to existing functionality
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Add function caller_sites verification in python api SmoothHacker/binaryninja-api
3 participants
@psifertex @fuzyll @plafosse