Skip to content

Transform package names for iOS/Android #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mdjastrzebski opened this issue May 9, 2025 · 2 comments · May be fixed by #327
Open

Transform package names for iOS/Android #317

mdjastrzebski opened this issue May 9, 2025 · 2 comments · May be fixed by #327
Assignees
@mdjastrzebski
Labels
good first issue Good for newcomers

Comments

@mdjastrzebski
Copy link
Member

Environment

RNEF 0.7.6
Create test app straight from template and make it contains hyphen (-), e.g. brownfield-test

Description

When app name contains hyphen, then the iOS package names becomes invalid:

warn Invalid application's package name "com.brownfield-test" in either 'AndroidManifest.xml' or 'build.gradle'. Read guidelines for setting the package name here: https://developer.android.com/studio/build/application-id

This could be easily avoided if we either:

  1. Disallowed hyphens (but I like hypens, they are so popular in JS)
  2. If the name contains hyphens, transform it from kebab-case to PascalCase for iOS/Android use cases.

Reproducible Demo
@thymikee thymikee added the good first issue Good for newcomers label May 9, 2025
@thymikee
Copy link
Member

thymikee commented May 9, 2025

Sounds like good first issue for someone to start contributing!

@mdjastrzebski
Copy link
Member Author

Might be somewhat tricky, as now we do not account for places that require kebab-case vs PascalCase when renaming the HelloWorld

@mdjastrzebski mdjastrzebski self-assigned this May 12, 2025
@mdjastrzebski mdjastrzebski linked a pull request May 12, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdjastrzebski mdjastrzebski

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@thymikee @mdjastrzebski