Unused TRoleClaim in Microsoft.Extensions.Identity.Stores.UserStore class

[pournasserian]

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

Here is the generic definitions in Microsoft.Extensions.Identity.Stores.UserStore (line 93):

where TUser : IdentityUser<TKey>
where TRole : IdentityRole<TKey>
where TContext : DbContext
where TKey : IEquatable<TKey>
where TUserClaim : IdentityUserClaim<TKey>, new()
where TUserRole : IdentityUserRole<TKey>, new()
where TUserLogin : IdentityUserLogin<TKey>, new()
where TUserToken : IdentityUserToken<TKey>, new()
where TRoleClaim : IdentityRoleClaim<TKey>, new()

The UserStore inherits from UserStoreBase.

None if them requires TRoleClaim and it is not used.

Expected Behavior

I think this line should be removed:

where TRoleClaim : IdentityRoleClaim<TKey>, new()

Steps To Reproduce

No response

Exceptions (if any)

No response

.NET Version

8

Anything else?

No response

[MackinnonBuck]

Thanks for reaching out, @pournasserian.

The UserStore inherits from UserStoreBase.
None if them requires TRoleClaim and it is not used.

@HaoK, it does appear that the TRoleClaim generic parameter doesn't need to be in UserStoreBase. Do you happen to know why it was added in the first place?

Note that even if it could be removed, we wouldn't do so because it would be a breaking change.

[MackinnonBuck]

Closing this out. We're interested in the history of this change but are not going to make a breaking change here.