Skip to content

Improve browser test shell #24236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
brendandahl opened this issue May 1, 2025 · 1 comment
Open

Improve browser test shell #24236

brendandahl opened this issue May 1, 2025 · 1 comment

Comments

@brendandahl
Copy link
Collaborator

brendandahl commented May 1, 2025 •
edited
Loading

With small browser windows the spinner, progress bar, and status text shift around causing the canvas below them to be at a different location from when the test starts. Ideally these things wouldn't cause the layout shift around. This can be observed in browser.test_sdl_mouse when using a small window.

Some options:

  1. Use a test only shell.html that has the minimal amount elements.
  2. Change shell.html to have a fixed size top bar that doesn't affect the content below.
brendandahl added a commit to brendandahl/emscripten that referenced this issue May 1, 2025
@brendandahl
Fix flaky browser.test_sdl_mouse in Chrome.
506432f 
In small windows the spinner, progress bar, and status text shift around
causing the canvas below them to be at a different location from when
the test starts.

I've filed emscripten-core#24236 about better ways to fix this. For now, this seems like
the smallest change.
@brendandahl brendandahl mentioned this issue May 1, 2025
Merged
brendandahl added a commit to brendandahl/emscripten that referenced this issue May 2, 2025
@brendandahl
Fix flaky browser.test_sdl_mouse in Chrome.
df67bb2 
In small windows the spinner, progress bar, and status text shift around
causing the canvas below them to be at a different location from when
the test starts.

I've filed emscripten-core#24236 about better ways to fix this. For now, this seems like
the smallest change.
brendandahl added a commit that referenced this issue May 2, 2025
@brendandahl
Fix flaky browser.test_sdl_mouse in Chrome. (#24237)
0bae7e4 
In small windows the spinner, progress bar, and status text shift around
causing the canvas below them to be at a different location from when
the test starts.

I've filed #24236 about better ways to fix this. For now, this seems
like the smallest change.
@sbc100
Copy link
Collaborator

sbc100 commented May 5, 2025

Another option: Ensure that all DOM manipulation relating to these elements happens before main is run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sbc100 @brendandahl