Skip to content

Full Pydantic v2 upgrade ⏫ #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tylerflex opened this issue Nov 8, 2023 · 1 comment · May be fixed by #2433
Open

Full Pydantic v2 upgrade ⏫ #1239

tylerflex opened this issue Nov 8, 2023 · 1 comment · May be fixed by #2433
Assignees
Labels
2.9 will go into version 2.9.*

Comments

@tylerflex
Copy link
Collaborator

tylerflex commented Nov 8, 2023

We ported to pydantic 2.* by importing pydantic.v1, but it would be good to do a full port.

There are many internals that utilize v1 features, so it's an opportunity to dive pretty deep into the front end code, convert them to v2 syntax, and potentially simplify them if they are not needed anymore or there are simpler ways to handle them.

I took a stab at it here but couldn't get it 100% working and there are some loose ends I'm not 100% sure about. It's also possible these changes messed with our docs build, I didn't check that yet.

@daquinteroflex depending on how much time you have, maybe after the docs merging and poetry, we can try wrapping this up and that will help us future-proof tidy3d.

@daquinteroflex
Copy link
Collaborator

daquinteroflex commented Feb 9, 2024

@daquinteroflex daquinteroflex changed the title pydantic v2 port Full Pydantic v2 upgrade ⏫ Feb 20, 2025
@yaugenst-flex yaugenst-flex removed the qtin label Apr 4, 2025
@yaugenst-flex yaugenst-flex self-assigned this Apr 4, 2025
@yaugenst-flex yaugenst-flex added the 2.9 will go into version 2.9.* label May 7, 2025
@yaugenst-flex yaugenst-flex linked a pull request May 8, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.9 will go into version 2.9.*
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants