Skip to content

Restart prompt for unsaved resources shows even in an empty project with no open scenes #103335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Calinou opened this issue Feb 26, 2025 · 3 comments · May be fixed by #106121
Open

Restart prompt for unsaved resources shows even in an empty project with no open scenes #103335

Calinou opened this issue Feb 26, 2025 · 3 comments · May be fixed by #106121
Assignees
@KoBeWi
Labels
bug regression topic:editor
Milestone
4.5

Comments

@Calinou
Copy link
Member

Calinou commented Feb 26, 2025 •
edited
Loading

Tested versions

  • Reproducible in: 4.4.rc2
  • Not reproducible in: 4.3.stable

System information

Godot v4.4.rc (3ef055f) - Fedora Linux 41 (KDE Plasma) on X11 - X11 display driver, Multi-window, 1 monitor - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4090 (nvidia; 565.77) - 13th Gen Intel(R) Core(TM) i9-13900K (32 threads)

Issue description

The restart prompt for unsaved resources shows even in an empty project with no open scenes:

Image

This is a regression from #102017, as this dialog wasn't present before. It can be confusing to see this dialog if there's nothing that can be saved, since the user might think they have unsaved resources when they don't.

Steps to reproduce

  • Create a new project and open it in the editor.
  • Do not create or open any scenes/resources.
  • Change a setting that requires a restart, then click the Save & Restart button.
  • A restart dialog shows up, but choosing Don't save or Save & Reload will do the same thing as there is nothing to save.

Minimal reproduction project (MRP)

N/A
@Calinou Calinou added this to the 4.4 milestone Feb 26, 2025
@Calinou Calinou moved this from Unassessed to Not Critical in 4.x Release Blockers Feb 26, 2025
@KoBeWi
Copy link
Member

KoBeWi commented Feb 26, 2025 •
edited
Loading

Changing project/editor settings marks global history as unsaved. There is no way to differentiate that from actual resource modifiactions and the dialog is somewhat expected in this case.

Image

@Calinou
Copy link
Member Author

Calinou commented Feb 27, 2025

There is no way to differentiate that from actual resource modifiactions and the dialog is somewhat expected in this case.

Can we get a list of modified resources and skip the dialog if the only modified resource is of type EditorSettings?

@KoBeWi
Copy link
Member

KoBeWi commented Feb 27, 2025 •
edited
Loading

Not sure if such list is even available. Also the editor only checks whether the undo history is "unsaved" (i.e. it has actions performed since the last save), so they'd need to be checked too.

@akien-mga akien-mga modified the milestones: 4.4, 4.5 Mar 2, 2025
@KoBeWi KoBeWi linked a pull request May 6, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KoBeWi KoBeWi

Labels
bug regression topic:editor
Projects
4.x Release Blockers
Status: Not Critical
Milestone
4.5
Development

Successfully merging a pull request may close this issue.

Allow undoredo actions to not make history unsaved KoBeWi/godot
3 participants
@Calinou @KoBeWi @akien-mga