Skip to content

[Bug]: objectContaining matches non-object values #15420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
flovouin opened this issue Dec 18, 2024 · 5 comments · May be fixed by #15463
Closed

[Bug]: objectContaining matches non-object values #15420

flovouin opened this issue Dec 18, 2024 · 5 comments · May be fixed by #15463
Labels
Bug Report Needs Triage Stale

Comments

@flovouin
Copy link

Version

29.7.0

Steps to reproduce

expect(undefined).toEqual(expect.objectContaining({}));
expect('test').toEqual(expect.objectContaining({}));
expect(1).toEqual(expect.objectContaining({}));
// Expecting the array to contain an object.
expect([]).toEqual([expect.objectContaining({})]);

Expected behavior

All tests above should fail.

Actual behavior

All tests pass.

Additional context

The documentation states that:

expect.objectContaining(object) matches any received object that recursively matches the expected properties. That is, the expected object is a subset of the received object.

However objectContaining can match any type, not just objects. This leads to all sorts of tests unexpectedly passing.

Environment

System:
    OS: macOS 15.2
    CPU: (10) arm64 Apple M1 Max
  Binaries:
    Node: 22.11.0 - ~/.asdf/installs/nodejs/22.11.0/bin/node
    npm: 10.9.0 - ~/.asdf/plugins/nodejs/shims/npm
  npmPackages:
    jest: ^29.7.0 => 29.7.0
@mohammednumaan
Copy link
Contributor

@flovouin Indeed. We are only validating the object passed into the objectContaining method and not the received value.

Image

I added the check for the other argument locally and it works. It does not match non-object values as shown below.
@SimenB what impact would it have if we validated the received argument as well?

Image

If possible can I work on this issue?

This was referenced Jan 16, 2025
Closed
Open
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Feb 15, 2025
@github-actions GitHub Actions
Copy link

This issue was closed because it has been stalled for 30 days with no activity. Please open a new issue if the issue is still relevant, linking to this one.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 17, 2025
@github-actions GitHub Actions
Copy link

This issue was closed because it has been stalled for 30 days with no activity. Please open a new issue if the issue is still relevant, linking to this one.

@github-actions GitHub Actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug Report Needs Triage Stale
Projects
None yet
Milestone
No milestone
2 participants
@flovouin @mohammednumaan