-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Axial to planar gradiometer transformation #9609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello! 👋 Thanks for opening your first issue here! ❤️ We will try to get back to you soon. 🚴🏽♂️ |
Thanks @PiusKern. |
FieldTrip supports different methods on how to compute planar from axial grads: For the combination of the vertical and horizontal parts, using an SVD is one option, |
I would start with just the |
FWIW, there is some rather old opinion by Robert, referring to simulations, saying the But I agree, if it's there, let's start with it and then we can always add this (and compare again, if we are feeling adventurous 😉 ) |
@larsoner What would be a good API for this / where should this live? |
We have
where I suggest just these three string options to start because in this issue Under the hood this should use the same underlying machinery as I like |
@britta-wstnr I'm bumping the milestone as 0.24 is going to be released in just a week or so, but it could still make 0.24 if you have time for it |
I forgot we had come up with an API for this! Just one more hint to add to what I wrote above, I think internally you should "just" need an appropriate call to |
nice, thanks @larsoner ! |
Hi, I am wondering if there has been a function to transform axial gradiometers to virtual planar gradiometers? I have tried the as_type() function. However, it fails on my CTF275 data. |
No it has not been implemented yet, still needs a volunteer to give it a shot |
Hi all, after a discussion with @britta-wstnr I would like to take over this issue.
@larsoner do you still think this is still a good API? Additionally, I see that you decided on |
Yeah @contsili that would be great! We can always add other projection methods via a new keyword argument later. I think in principle the PR should be fairly straightforward 🤞 One issue is that we'll need to store the canonical CTF and Neuromag sensor definitions somewhere (positions, orientations, and coil def number). I don't think we currently do that anywhere as we rely on this info to be stored in a given file being read with |
@larsoner, could you point me to where the |
I think it is implicitly what we use already in mne-python/mne/channels/interpolation.py Line 208 in b38385e
which wraps to
But really I don't think you need to worry about the mapping method for now. The critical part is that we already have a function that allows mapping from one sensor type (given a suitable |
Hi @contsili! 👋 Are you still interested in tackling this? 🙂 |
Hi @britta-wstnr . Yes I am still interested. I started working and I have less time but I will do it! I think a good plan is to wait for this PR #13044 to be merged and then I can extend the functionality of |
Hi @contsili! Great to hear 🙌 |
For axial gradiometer data, e.g. from CTF 275 systems, a transformation to virtual planar gradiometers would be helpful. This is a standard procedure in many data analysis pipelines for axial systems. It would facilitate plotting and subsequent interpretation.
The issue has been briefly discussed during the office hour on 2021-07-23.
@britta-wstnr
The text was updated successfully, but these errors were encountered: