Add solution for test container

Author: VincentLanglet

extension.neon

@@ -13,9 +13,6 @@ parameters:
 		- stubs/Psr/Cache/CacheItemInterface.stub
 		- stubs/Psr/Cache/InvalidArgumentException.stub
 		- stubs/Symfony/Bundle/FrameworkBundle/Controller/AbstractController.stub
-		- stubs/Symfony/Bundle/FrameworkBundle/KernelBrowser.stub
-		- stubs/Symfony/Bundle/FrameworkBundle/Test/KernelTestCase.stub
-		- stubs/Symfony/Bundle/FrameworkBundle/Test/TestContainer.stub
 		- stubs/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/AuthenticatorFactoryInterface.stub
 		- stubs/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/FirewallListenerFactoryInterface.stub
 		- stubs/Symfony/Component/Console/Command.stub
@@ -364,3 +361,9 @@ services:
 		class: PHPStan\Symfony\SymfonyContainerResultCacheMetaExtension
 		tags:
 			- phpstan.resultCacheMetaExtension
+	-
+		class: PHPStan\Type\Symfony\Container\KernelBrowserGetContainerDynamicReturnTypeExtension
+		tags: [phpstan.broker.dynamicMethodReturnTypeExtension]
+	-
+		class: PHPStan\Type\Symfony\Container\KernelTestCaseGetContainerDynamicReturnTypeExtension
+		tags: [phpstan.broker.dynamicStaticMethodReturnTypeExtension]

src/Rules/Symfony/ContainerInterfacePrivateServiceRule.php

@@ -10,6 +10,7 @@
 use PHPStan\Symfony\ServiceMap;
 use PHPStan\TrinaryLogic;
 use PHPStan\Type\ObjectType;
+use PHPStan\Type\Symfony\Container\TestContainerType;
 use PHPStan\Type\Type;
 use function sprintf;
 
@@ -43,11 +44,17 @@ public function processNode(Node $node, Scope $scope): array
 
 		$argType = $scope->getType($node->var);
 
-		$isTestContainerType = (new ObjectType('Symfony\Bundle\FrameworkBundle\Test\TestContainer'))->isSuperTypeOf($argType);
+		if (
+			$argType instanceof TestContainerType
+			|| (new ObjectType('Symfony\Bundle\FrameworkBundle\Test\TestContainer'))->isSuperTypeOf($argType)->yes()
+		) {
+			return [];
+		}
+
 		$isOldServiceSubscriber = (new ObjectType('Symfony\Component\DependencyInjection\ServiceSubscriberInterface'))->isSuperTypeOf($argType);
 		$isServiceSubscriber = $this->isServiceSubscriber($argType, $scope);
 		$isServiceLocator = (new ObjectType('Symfony\Component\DependencyInjection\ServiceLocator'))->isSuperTypeOf($argType);
-		if ($isTestContainerType->yes() || $isOldServiceSubscriber->yes() || $isServiceSubscriber->yes() || $isServiceLocator->yes()) {
+		if ($isOldServiceSubscriber->yes() || $isServiceSubscriber->yes() || $isServiceLocator->yes()) {
 			return [];
 		}
 

src/Type/Symfony/Container/KernelBrowserGetContainerDynamicReturnTypeExtension.php

@@ -0,0 +1,31 @@
+<?php
+
+declare(strict_types=1);
+
+namespace PHPStan\Type\Symfony\Container;
+
+use PhpParser\Node\Expr\MethodCall;
+use PHPStan\Analyser\Scope;
+use PHPStan\Reflection\MethodReflection;
+use PHPStan\Type\DynamicMethodReturnTypeExtension;
+use PHPStan\Type\Type;
+
+final class KernelBrowserGetContainerDynamicReturnTypeExtension implements DynamicMethodReturnTypeExtension
+{
+
+	public function getClass(): string
+	{
+		return 'Symfony\Bundle\FrameworkBundle\KernelBrowser';
+	}
+
+	public function isMethodSupported(MethodReflection $methodReflection): bool
+	{
+		return $methodReflection->getName() === 'getContainer';
+	}
+
+	public function getTypeFromMethodCall(MethodReflection $methodReflection, MethodCall $methodCall, Scope $scope): ?Type
+	{
+		return new TestContainerType();
+	}
+
+}

src/Type/Symfony/Container/KernelTestCaseGetContainerDynamicReturnTypeExtension.php

@@ -0,0 +1,31 @@
+<?php
+
+declare(strict_types=1);
+
+namespace PHPStan\Type\Symfony\Container;
+
+use PhpParser\Node\Expr\StaticCall;
+use PHPStan\Analyser\Scope;
+use PHPStan\Reflection\MethodReflection;
+use PHPStan\Type\DynamicStaticMethodReturnTypeExtension;
+use PHPStan\Type\Type;
+
+final class KernelTestCaseGetContainerDynamicReturnTypeExtension implements DynamicStaticMethodReturnTypeExtension
+{
+
+	public function getClass(): string
+	{
+		return 'Symfony\Bundle\FrameworkBundle\Test\KernelTestCase';
+	}
+
+	public function isStaticMethodSupported(MethodReflection $methodReflection): bool
+	{
+		return $methodReflection->getName() === 'getContainer';
+	}
+
+	public function getTypeFromStaticMethodCall(MethodReflection $methodReflection, StaticCall $methodCall, Scope $scope): ?Type
+	{
+		return new TestContainerType();
+	}
+
+}

src/Type/Symfony/Container/TestContainerType.php

@@ -0,0 +1,20 @@
+<?php
+
+declare(strict_types=1);
+
+namespace PHPStan\Type\Symfony\Container;
+
+use PHPStan\Reflection\ClassReflection;
+use PHPStan\Type\ObjectType;
+use PHPStan\Type\Type;
+
+class TestContainerType extends ObjectType
+{
+	public function __construct(
+		string $class = 'Symfony\Component\DependencyInjection\ContainerInterface',
+		?Type $subtractedType = null,
+		?ClassReflection $classReflection = null
+	) {
+		parent::__construct($class, $subtractedType, $classReflection);
+	}
+}

stubs/Symfony/Bundle/FrameworkBundle/KernelBrowser.stub

@@ -77,4 +77,21 @@ public function testGetPrivateServiceInServiceSubscriber(): void
 		);
 	}
 
+	public function testGetPrivateServiceInTest(): void
+	{
+		$this->analyse(
+			[
+				__DIR__ . '/ExampleTest.php',
+			],
+			[],
+		);
+	}
+
+	public static function getAdditionalConfigFiles(): array
+	{
+		return [
+			__DIR__ . '/container-extensions.neon',
+		];
+	}
+
 }

stubs/Symfony/Bundle/FrameworkBundle/Test/KernelTestCase.stub

@@ -0,0 +1,25 @@
+<?php
+
+declare(strict_types=1);
+
+namespace PHPStan\Rules\Symfony;
+
+use Symfony\Bundle\FrameworkBundle\KernelBrowser;
+use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
+
+class ExampleTest extends KernelTestCase
+{
+
+	public function test(): void
+	{
+		$container = self::getContainer();
+		$container->get('private');
+	}
+
+	public function foo(KernelBrowser $browser): void
+	{
+		$container = $browser->getContainer();
+		$container->get('private');
+	}
+
+}

stubs/Symfony/Bundle/FrameworkBundle/Test/TestContainer.stub

@@ -0,0 +1,7 @@
+services:
+	-
+		class: PHPStan\Type\Symfony\Container\KernelBrowserGetContainerDynamicReturnTypeExtension
+		tags: [phpstan.broker.dynamicMethodReturnTypeExtension]
+	-
+		class: PHPStan\Type\Symfony\Container\KernelTestCaseGetContainerDynamicReturnTypeExtension
+		tags: [phpstan.broker.dynamicStaticMethodReturnTypeExtension]