Skip to content

[RayCluster][Expectation] Add a test to ensure expectations work well during scaling down #3533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 2 tasks
kevin85421 opened this issue May 3, 2025 · 3 comments · Fixed by #3543
Closed
1 of 2 tasks

[RayCluster][Expectation] Add a test to ensure expectations work well during scaling down #3533

kevin85421 opened this issue May 3, 2025 · 3 comments · Fixed by #3543
Assignees
@kenchung285
Labels
1.4.0 enhancement New feature or request good-first-issue Good for newcomers raycluster

Comments

@kevin85421
Copy link
Member

kevin85421 commented May 3, 2025 •
edited
Loading

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Add a test for #3520.

My current idea is:

Without #3520, it’s possible for more than one Pod to have deletionTimestamp set.

Use case

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@kevin85421 kevin85421 added enhancement New feature or request triage raycluster 1.4.0 and removed triage labels May 3, 2025
@kevin85421
Copy link
Member Author

cc @MortalHappiness

@kevin85421 kevin85421 added the good-first-issue Good for newcomers label May 3, 2025
@kevin85421
Copy link
Member Author

Since we’re close to the branch cut, it’s best to have a PR submitted within a week.

@kenchung285
Copy link
Contributor

kenchung285 commented May 4, 2025 •
edited
Loading

Hi @kevin85421 , may I try this?

@kenchung285 kenchung285 mentioned this issue May 5, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kenchung285 kenchung285

Labels
1.4.0 enhancement New feature or request good-first-issue Good for newcomers raycluster
Projects
None yet
Milestone
No milestone
2 participants
@kevin85421 @kenchung285