Skip to content

[python][RDF] Add Support for String Columns in AsRVec #18571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2025
Merged

[python][RDF] Add Support for String Columns in AsRVec #18571

merged 2 commits into from
May 7, 2025

Conversation

siliataider
Copy link
Contributor

@siliataider siliataider commented Apr 30, 2025 •
edited
Loading

This Pull request:

Changes or fixes:

This PR extends support for strings stored in NumPy arrays with dtype=object or dtype=numpy.str_ in AsRVec, enabling conversions of dataframes with string columns to RDataFrame using FromNumpy and FromPandas.

Checklist:

  • tested changes locally

This PR fixes #18534

@siliataider siliataider requested a review from guitargeek April 30, 2025 17:34
@siliataider siliataider self-assigned this Apr 30, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2025 •
edited
Loading

Test Results

    19 files      19 suites   4d 9h 41m 11s ⏱️
 2 731 tests  2 731 ✅ 0 💤 0 ❌
50 414 runs  50 414 ✅ 0 💤 0 ❌

Results for commit e9ce69e.

♻️ This comment has been updated with latest results.

vepadulano
vepadulano requested changes May 5, 2025
View reviewed changes
Copy link
Member

@vepadulano vepadulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left some comments to discuss

@siliataider siliataider requested a review from vepadulano May 5, 2025 16:23
@siliataider siliataider force-pushed the FromPandas-str branch 2 times, most recently from 4290ecc to 4071850 Compare May 6, 2025 13:24
@siliataider siliataider mentioned this pull request May 6, 2025
Merged
1 task
@siliataider siliataider force-pushed the FromPandas-str branch 3 times, most recently from 69413ef to e9ce69e Compare May 6, 2025 14:44
vepadulano
vepadulano approved these changes May 6, 2025
View reviewed changes
Copy link
Member

@vepadulano vepadulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM!

@siliataider siliataider merged commit fdea555 into root-project:master May 7, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepadulano vepadulano vepadulano approved these changes

@dpiparo dpiparo Awaiting requested review from dpiparo dpiparo is a code owner

@guitargeek guitargeek Awaiting requested review from guitargeek

Assignees

@siliataider siliataider

Labels
in:Python Interface in:RDataFrame
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot use FromPandas with string columns
2 participants
@siliataider @vepadulano