Skip to content

Make sure that even exception does not abort progress bar rendering on the middle #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Martoon-00 opened this issue Nov 20, 2022 · 1 comment · May be fixed by #269
Open

Make sure that even exception does not abort progress bar rendering on the middle #222

Martoon-00 opened this issue Nov 20, 2022 · 1 comment · May be fixed by #269
Assignees
@aeqz
Milestone
0.3.0

Comments

@Martoon-00
Copy link
Member

Clarification and motivation

In #163 we have fixed the progress bar rendering thread to never abort in the middle of printing disregard when the links verification has finished. Now the terminal is not supposed to periodically appear in some weird state after xrefcheck completes.

However in case of an async exception (it may be a UserInterrupt which we now handle), AFAIS we still let the progress bar to be rendered partially, and this seems to be as bad as having a not cleaned up resource.

Acceptance criteria

  • Even in case of exceptions we never render the terminal partially.
  • Double ^C should still abort the application immediately.
@Martoon-00 Martoon-00 added this to the 0.3.0 milestone Nov 20, 2022
@Martoon-00
Copy link
Member Author

Also see my suggestion here.

aeqz added a commit that referenced this issue Jan 23, 2023
@aeqz
[#222] Prevent progress bar rendering from abort
44fef9f 
Problem: It seems that the current progress bar rendering action is not
completely protected against exceptions.

Solution: As it is an action that runs for a short amount of time and we
really want it to not be interrputed, we can wrap it with
uninterruptibleMask. The resulting rendering loop also gets simpler with
this change.
@aeqz aeqz self-assigned this Jan 23, 2023
@aeqz aeqz linked a pull request Jan 23, 2023 that will close this issue
Open
8 tasks
aeqz added a commit that referenced this issue Jan 27, 2023
@aeqz
[#222] Prevent progress bar rendering from abort
fc991f9 
Problem: It seems that the current progress bar rendering action is not
completely protected against exceptions.

Solution: As it is an action that runs for a short amount of time and we
really want it to not be interrputed, we can wrap it with
uninterruptibleMask. The resulting rendering loop also gets simpler with
this change.
aeqz added a commit that referenced this issue Feb 1, 2023
@aeqz
[#222] Prevent progress bar rendering from abort
a7a85f7 
Problem: It seems that the current progress bar rendering action is not
completely protected against exceptions.

Solution: As it is an action that runs for a short amount of time and we
really want it to not be interrputed, we can wrap it with
uninterruptibleMask. The resulting rendering loop also gets simpler with
this change.
aeqz added a commit that referenced this issue Aug 31, 2023
@aeqz
[#222] Prevent progress bar rendering from abort
202706e 
Problem: It seems that the current progress bar rendering action is not
completely protected against exceptions.

Solution: As it is an action that runs for a short amount of time and we
really want it to not be interrputed, we can wrap it with
uninterruptibleMask. The resulting rendering loop also gets simpler with
this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeqz aeqz

Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

[#222] Prevent progress bar rendering from abort serokell/xrefcheck
2 participants
@Martoon-00 @aeqz