Standardize application task executor 44946 #44965
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shivam Thorat <shivamthorat2103@gmail.com>
This commit provides a more consistent way to access the applicationTaskExecutor bean across different Spring integrations by enhancing the ApplicationTaskExecutorBuilder. It updates MVC, WebFlux, and GraphQL to follow the same pattern, provides better type safety, and improves documentation. Fixes spring-projects#44946 Signed-off-by: Shivam Thorat <shivamthorat2103@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks for the PR, @shivammm21. I'm sorry to do this again, but we can't yet accept a contribution for this. #44946 has not yet be triaged and as the description states, it's not clear what needs to be done in some situations. Thanks for your enthusiasm here. As I already recommended please comment on an issue and wait until it's assigned to you before working on a PR so that we can avoid wasted effort. |
wilkinsona
added
status: declined
|
Yeah, I am really sorry, I will take care of it. I will change the code after I get assigned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #44946 by standardizing how
applicationTaskExecutoris accessed across Spring integrations.Problem
The current setup is complex with inconsistencies:
applicationTaskExecutorbut with different type requirementsAsyncTaskExecutorExecutorSolution
ApplicationTaskExecutorBuilderwith typed accessor methods:getExecutor()- Returns basicExecutor(suitable for GraphQL)getAsyncTaskExecutor()- ReturnsAsyncTaskExecutor(for MVC, WebFlux, WebSocket)getTaskExecutor()- ReturnsTaskExecutor(for other integrations)This provides a more consistent, type-safe way to access the same underlying executor across all Spring Boot integrations while maintaining backward compatibility.
Fixes #44946