Skip to content

AuthorizationProxyFactory.proxy should return the same type that is passed into the method #16706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rwinch opened this issue Mar 7, 2025 · 2 comments
Closed

AuthorizationProxyFactory.proxy should return the same type that is passed into the method #16706

rwinch opened this issue Mar 7, 2025 · 2 comments
Assignees
@jzheaux
Labels
in: core An issue in spring-security-core status: duplicate A duplicate of another issue type: enhancement A general enhancement

Comments

@rwinch
Copy link
Member

rwinch commented Mar 7, 2025 •
edited
Loading

This would make it type safe for consumers of the API. Instead of

Service service = (Service) factory.proxy(new Service());

it could be written

Service service = factory.proxy(new Service());

NOTE: I think this might be a change fore 7.0
@rwinch rwinch added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Mar 7, 2025
@rwinch rwinch added this to the 7.0.0-M1 milestone Mar 7, 2025
@rwinch
Copy link
Member Author

rwinch commented Mar 7, 2025

cc @jzheaux

@big-cir big-cir mentioned this issue Apr 25, 2025
Open
@jzheaux jzheaux added in: core An issue in spring-security-core and removed status: waiting-for-triage An issue we've not yet triaged labels May 1, 2025
@jzheaux jzheaux self-assigned this May 1, 2025
@jzheaux
Copy link
Contributor

jzheaux commented May 1, 2025

Closing in favor of #16996

@jzheaux jzheaux closed this as completed May 1, 2025
@jzheaux jzheaux added the status: duplicate A duplicate of another issue label May 1, 2025
@jzheaux jzheaux removed this from the 7.0.0-M1 milestone May 1, 2025
big-cir added a commit to big-cir/spring-security that referenced this issue May 8, 2025
@big-cir
Make AuthorizationProxyFactory#proxy Generic
f4eda99 
Closes spring-projectsgh-16706
big-cir added a commit to big-cir/spring-security that referenced this issue May 8, 2025
@big-cir
Make AuthorizationProxyFactory#proxy Generic
3c8a94d 
Closes spring-projectsgh-16706

Signed-off-by: dae won <eodnjs01477@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: core An issue in spring-security-core status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rwinch @jzheaux