Skip to content

mgmt: hawkbit: hawkbit_autohandler_wait() returns to early #89342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maass-hamburg opened this issue Apr 30, 2025 · 2 comments · Fixed by #88406
Closed

mgmt: hawkbit: hawkbit_autohandler_wait() returns to early #89342

maass-hamburg opened this issue Apr 30, 2025 · 2 comments · Fixed by #88406
Assignees
Labels
area: hawkBit bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@maass-hamburg
Copy link
Collaborator

maass-hamburg commented Apr 30, 2025

Describe the bug
the k_event_clear in the work might be to late sometimes, when
hawkbit_autohandler_wait() is executed directly after
hawkbit_autohandler(). This leads to getting the events
of the former execution and also not waiting until the
current autohandler run is finished.

To Reproduce
Steps to reproduce the behavior:

  1. west build -p -b stm32h573i_dk samples/subsys/mgmt/hawkbit -- -DCONF_FILE="prj.conf overlay-runtime.conf" && west flash
  2. let the autohandler run by it self
  3. hawkbit run
  4. See error ( the shell command returns directly and doesn't block, also the return value is the one from the previous run)

Expected behavior
the shell command should block until the requested execution is completed

Impact
as long as hawkbit_autohandler_wait() is just used to wait for the first start, it shouldn't be a problem. For the shell it would mostly just result, in some misleading shell output.

@maass-hamburg maass-hamburg added the bug The issue is a bug, or the PR is fixing a bug label Apr 30, 2025
@dkalowsk
Copy link
Collaborator

dkalowsk commented May 6, 2025

@maass-hamburg can you please use the bug template to fill out the missing information for others looking at the issue.

@dkalowsk dkalowsk added the priority: low Low impact/importance bug label May 6, 2025
@maass-hamburg
Copy link
Collaborator Author

@maass-hamburg can you please use the bug template to fill out the missing information for others looking at the issue.

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: hawkBit bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants