Implements Heading Customization for the Reactions Block #1657
Conversation
Implements heading customization for the Reactions block using InnerBlocks, allowing users to: - Edit heading text - Change heading level (H1-H6) - Remove heading if desired - Apply standard Gutenberg heading styles Similar to Jetpack's Related Posts block implementation. Fixes Automattic#1096
github-actions
bot
added
[Block] Reactions
[Feature] Reactions
[Focus] Editor
src/reactions/reactions.js
Outdated
| </div> | ||
| ); | ||
| export function Reactions({ | ||
| postId = null, |
There was a problem hiding this comment.
please use tabs instead of spaces.
|
Thanks for your contribution @vk17-starlord Can you please use |
|
ok @pfefferle will implement those changes |
|
@pfefferle - when i run 'NPM RUN BUILD' it still generated build files for all blocks and other unnecessary files which I haven't touched |
|
@pfefferle - Have converted spaces to tabs using vscode shortcut please check formatting and logic once |
|
@vk17-starlord I just ran the npm script on your branch and it removed all the map files and minified the JS/CSS as it should. Have you stopped the |
Yes I had stopped NPM RUN DEV before running NPM RUN BUILD . The NPM RUN BUILD script is building all blocks which haven't been changed |
|
I created a new branch and copied the reaction block code. Initially, VSCode showed only 3 file changes in the top-left source control panel:
However, after running
|
That should be fine, it should just update the hashes. Please go ahead and just run |
|
@obenland - have already pushed the code you can check it out and review |
There was a problem hiding this comment.
This is pretty close. There are quite a few whitespace changes currently, would you mind reverting these to stay closer to WP coding standards?
| setLoading(false); | ||
| }) | ||
| .catch(() => setLoading(false)); | ||
| }, [postId, providedReactions, namespace]); |
There was a problem hiding this comment.
I'm not sure we need to add namespace here? It should be constant.
| @@ -18,12 +18,7 @@ | |||
| } | |||
| } | |||
| }, | |||
| "attributes": { | |||
There was a problem hiding this comment.
This seems problematic as it will create validation errors for existing users of the block, whenever they try to visualize the block in the site editor.
I would recommend implementing deprecation to avoid that.
| key={key} | ||
| items={group.items} | ||
| label={group.label} |
There was a problem hiding this comment.
Your editor doesn't seem to pick up the configuration from this project's .editorconfig file. Could you keep the spaces inside brackets and parenthesis in the file?
This PR introduces enhancements to the Reactions block, enabling users to customize the heading using Gutenberg's InnerBlocks. The updates provide flexibility and control over the heading display.
Key Features:
This implementation is inspired by Jetpack's Related Posts block and aims to provide a similar level of customization.
Fixes:
Proposed Changes:
Changelog Entry:
Significance:
Type: