Add ccp_replication_slots to OTel metrics. #4167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminjb
reviewed
May 6, 2025
| fiveSecondMetricsClone, err = appendToJSONArray(fiveSecondMetricsClone, eqPG16) | ||
| } | ||
| if err != nil { | ||
| log.Error(err, "error compiling postgres metrics") |
There was a problem hiding this comment.
Now that I look at this again, I wish the errors had some differentiation so that we could pinpoint which appendToJSONArray actually errored. (This may be scope creep as it doesn't entirely fall within this ticket.)
There was a problem hiding this comment.
I'd like to get this merged sooner than later so I can move on to fixing the intervals for certain queries; however, I'm going to be touching this code again when working on that, so I could improve the error messages then
tony-landreth
approved these changes
May 6, 2025
Use COALESCE to change NULLs to zero-values.
dsessler7
force-pushed
the
otel-add-ccp-replication-slots
branch
from
069703e to
474c06d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
The ccp_replication_slots metrics are not present when using OTel.
What is the new behavior (if this is a feature change)?
The ccp_replication_slots metrics are added to the OTel metrics collection.
Other Information: