Update Docker build image #8754
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
tag: no release notes
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 66 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.49.0-SNAPSHOT~b8f44409b6, baseline=1.49.0-SNAPSHOT~b445667208
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.007 s) : 0, 1006578
Total [baseline] (10.458 s) : 0, 10458231
Agent [candidate] (1.006 s) : 0, 1005655
Total [candidate] (10.5 s) : 0, 10499623
section appsec
Agent [baseline] (1.148 s) : 0, 1147909
Total [baseline] (10.706 s) : 0, 10706210
Agent [candidate] (1.155 s) : 0, 1154642
Total [candidate] (10.66 s) : 0, 10659656
section iast
Agent [baseline] (1.138 s) : 0, 1137725
Total [baseline] (10.853 s) : 0, 10853140
Agent [candidate] (1.14 s) : 0, 1140201
Total [candidate] (10.834 s) : 0, 10834143
section profiling
Agent [baseline] (1.257 s) : 0, 1256698
Total [baseline] (10.727 s) : 0, 10727290
Agent [candidate] (1.27 s) : 0, 1270345
Total [candidate] (10.818 s) : 0, 10818402
gantt
title petclinic - break down per module: candidate=1.49.0-SNAPSHOT~b8f44409b6, baseline=1.49.0-SNAPSHOT~b445667208
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (670.562 ms) : 0, 670562
BytebuddyAgent [candidate] (671.051 ms) : 0, 671051
GlobalTracer [baseline] (240.308 ms) : 0, 240308
GlobalTracer [candidate] (240.425 ms) : 0, 240425
AppSec [baseline] (54.748 ms) : 0, 54748
AppSec [candidate] (54.643 ms) : 0, 54643
Debugger [baseline] (6.171 ms) : 0, 6171
Debugger [candidate] (6.173 ms) : 0, 6173
Remote Config [baseline] (702.202 µs) : 0, 702
Remote Config [candidate] (703.962 µs) : 0, 704
Telemetry [baseline] (10.617 ms) : 0, 10617
Telemetry [candidate] (9.224 ms) : 0, 9224
section appsec
BytebuddyAgent [baseline] (687.263 ms) : 0, 687263
BytebuddyAgent [candidate] (692.719 ms) : 0, 692719
GlobalTracer [baseline] (236.334 ms) : 0, 236334
GlobalTracer [candidate] (237.518 ms) : 0, 237518
IAST [baseline] (21.663 ms) : 0, 21663
IAST [candidate] (22.002 ms) : 0, 22002
AppSec [baseline] (174.611 ms) : 0, 174611
AppSec [candidate] (174.786 ms) : 0, 174786
Debugger [baseline] (5.895 ms) : 0, 5895
Debugger [candidate] (5.899 ms) : 0, 5899
Remote Config [baseline] (631.146 µs) : 0, 631
Remote Config [candidate] (632.357 µs) : 0, 632
Telemetry [baseline] (8.919 ms) : 0, 8919
Telemetry [candidate] (8.513 ms) : 0, 8513
section iast
BytebuddyAgent [baseline] (790.094 ms) : 0, 790094
BytebuddyAgent [candidate] (792.086 ms) : 0, 792086
GlobalTracer [baseline] (230.026 ms) : 0, 230026
GlobalTracer [candidate] (230.812 ms) : 0, 230812
IAST [baseline] (22.772 ms) : 0, 22772
IAST [candidate] (22.775 ms) : 0, 22775
AppSec [baseline] (56.6 ms) : 0, 56600
AppSec [candidate] (56.534 ms) : 0, 56534
Debugger [baseline] (6.007 ms) : 0, 6007
Debugger [candidate] (5.967 ms) : 0, 5967
Remote Config [baseline] (600.353 µs) : 0, 600
Remote Config [candidate] (592.421 µs) : 0, 592
Telemetry [baseline] (8.022 ms) : 0, 8022
Telemetry [candidate] (7.949 ms) : 0, 7949
section profiling
BytebuddyAgent [baseline] (661.847 ms) : 0, 661847
BytebuddyAgent [candidate] (671.753 ms) : 0, 671753
GlobalTracer [baseline] (378.653 ms) : 0, 378653
GlobalTracer [candidate] (381.388 ms) : 0, 381388
AppSec [baseline] (54.836 ms) : 0, 54836
AppSec [candidate] (54.024 ms) : 0, 54024
Debugger [baseline] (6.133 ms) : 0, 6133
Debugger [candidate] (6.187 ms) : 0, 6187
Remote Config [baseline] (649.743 µs) : 0, 650
Remote Config [candidate] (653.375 µs) : 0, 653
Telemetry [baseline] (8.122 ms) : 0, 8122
Telemetry [candidate] (8.217 ms) : 0, 8217
ProfilingAgent [baseline] (96.278 ms) : 0, 96278
ProfilingAgent [candidate] (97.162 ms) : 0, 97162
Profiling [baseline] (96.301 ms) : 0, 96301
Profiling [candidate] (97.186 ms) : 0, 97186
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.49.0-SNAPSHOT~b8f44409b6, baseline=1.49.0-SNAPSHOT~b445667208
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.014 s) : 0, 1013873
Total [baseline] (8.676 s) : 0, 8676046
Agent [candidate] (1.007 s) : 0, 1006997
Total [candidate] (8.623 s) : 0, 8622865
section iast
Agent [baseline] (1.135 s) : 0, 1135438
Total [baseline] (9.204 s) : 0, 9204435
Agent [candidate] (1.136 s) : 0, 1135775
Total [candidate] (9.234 s) : 0, 9233703
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.137 s) : 0, 1137125
Total [baseline] (9.204 s) : 0, 9204497
Agent [candidate] (1.14 s) : 0, 1139875
Total [candidate] (9.212 s) : 0, 9211915
section iast_TELEMETRY_OFF
Agent [baseline] (1.131 s) : 0, 1131216
Total [baseline] (9.208 s) : 0, 9207960
Agent [candidate] (1.133 s) : 0, 1132770
Total [candidate] (9.174 s) : 0, 9173992
gantt
title insecure-bank - break down per module: candidate=1.49.0-SNAPSHOT~b8f44409b6, baseline=1.49.0-SNAPSHOT~b445667208
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (675.64 ms) : 0, 675640
BytebuddyAgent [candidate] (671.055 ms) : 0, 671055
GlobalTracer [baseline] (241.406 ms) : 0, 241406
GlobalTracer [candidate] (239.825 ms) : 0, 239825
AppSec [baseline] (54.909 ms) : 0, 54909
AppSec [candidate] (54.41 ms) : 0, 54410
Debugger [baseline] (6.98 ms) : 0, 6980
Debugger [candidate] (7.714 ms) : 0, 7714
Remote Config [baseline] (706.666 µs) : 0, 707
Remote Config [candidate] (701.856 µs) : 0, 702
Telemetry [baseline] (10.656 ms) : 0, 10656
Telemetry [candidate] (9.914 ms) : 0, 9914
section iast
BytebuddyAgent [baseline] (789.794 ms) : 0, 789794
BytebuddyAgent [candidate] (789.378 ms) : 0, 789378
GlobalTracer [baseline] (229.894 ms) : 0, 229894
GlobalTracer [candidate] (229.662 ms) : 0, 229662
IAST [baseline] (22.552 ms) : 0, 22552
IAST [candidate] (22.538 ms) : 0, 22538
AppSec [baseline] (55.538 ms) : 0, 55538
AppSec [candidate] (56.429 ms) : 0, 56429
Debugger [baseline] (5.837 ms) : 0, 5837
Debugger [candidate] (5.907 ms) : 0, 5907
Remote Config [baseline] (590.895 µs) : 0, 591
Remote Config [candidate] (590.653 µs) : 0, 591
Telemetry [baseline] (7.826 ms) : 0, 7826
Telemetry [candidate] (7.916 ms) : 0, 7916
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (790.381 ms) : 0, 790381
BytebuddyAgent [candidate] (791.495 ms) : 0, 791495
GlobalTracer [baseline] (229.175 ms) : 0, 229175
GlobalTracer [candidate] (230.687 ms) : 0, 230687
IAST [baseline] (22.803 ms) : 0, 22803
IAST [candidate] (22.799 ms) : 0, 22799
AppSec [baseline] (56.81 ms) : 0, 56810
AppSec [candidate] (56.967 ms) : 0, 56967
Debugger [baseline] (5.968 ms) : 0, 5968
Debugger [candidate] (5.934 ms) : 0, 5934
Remote Config [baseline] (607.143 µs) : 0, 607
Remote Config [candidate] (602.914 µs) : 0, 603
Telemetry [baseline] (7.963 ms) : 0, 7963
Telemetry [candidate] (7.968 ms) : 0, 7968
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (785.707 ms) : 0, 785707
BytebuddyAgent [candidate] (786.844 ms) : 0, 786844
GlobalTracer [baseline] (229.368 ms) : 0, 229368
GlobalTracer [candidate] (229.991 ms) : 0, 229991
IAST [baseline] (22.216 ms) : 0, 22216
IAST [candidate] (22.18 ms) : 0, 22180
AppSec [baseline] (56.269 ms) : 0, 56269
AppSec [candidate] (56.263 ms) : 0, 56263
Debugger [baseline] (5.93 ms) : 0, 5930
Debugger [candidate] (5.862 ms) : 0, 5862
Remote Config [baseline] (590.343 µs) : 0, 590
Remote Config [candidate] (588.573 µs) : 0, 589
Telemetry [baseline] (7.722 ms) : 0, 7722
Telemetry [candidate] (7.698 ms) : 0, 7698
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~b8f44409b6, baseline=1.49.0-SNAPSHOT~b445667208
dateFormat X
axisFormat %s
section baseline
no_agent (1.363 ms) : 1344, 1382
. : milestone, 1363,
appsec (1.738 ms) : 1714, 1762
. : milestone, 1738,
appsec_no_iast (1.711 ms) : 1686, 1735
. : milestone, 1711,
code_origins (1.646 ms) : 1619, 1673
. : milestone, 1646,
iast (1.521 ms) : 1496, 1545
. : milestone, 1521,
profiling (1.521 ms) : 1499, 1544
. : milestone, 1521,
tracing (1.475 ms) : 1450, 1500
. : milestone, 1475,
section candidate
no_agent (1.371 ms) : 1351, 1391
. : milestone, 1371,
appsec (1.719 ms) : 1695, 1742
. : milestone, 1719,
appsec_no_iast (1.721 ms) : 1697, 1745
. : milestone, 1721,
code_origins (1.694 ms) : 1667, 1721
. : milestone, 1694,
iast (1.511 ms) : 1486, 1536
. : milestone, 1511,
profiling (1.51 ms) : 1487, 1533
. : milestone, 1510,
tracing (1.485 ms) : 1460, 1510
. : milestone, 1485,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~b8f44409b6, baseline=1.49.0-SNAPSHOT~b445667208
dateFormat X
axisFormat %s
section baseline
no_agent (386.486 µs) : 367, 406
. : milestone, 386,
iast (523.061 µs) : 500, 546
. : milestone, 523,
iast_FULL (730.741 µs) : 707, 754
. : milestone, 731,
iast_GLOBAL (568.262 µs) : 545, 591
. : milestone, 568,
iast_HARDCODED_SECRET_DISABLED (526.395 µs) : 503, 549
. : milestone, 526,
iast_INACTIVE (467.426 µs) : 444, 491
. : milestone, 467,
iast_TELEMETRY_OFF (502.623 µs) : 479, 526
. : milestone, 503,
tracing (455.864 µs) : 435, 477
. : milestone, 456,
section candidate
no_agent (385.007 µs) : 365, 405
. : milestone, 385,
iast (509.249 µs) : 487, 532
. : milestone, 509,
iast_FULL (729.009 µs) : 706, 752
. : milestone, 729,
iast_GLOBAL (568.592 µs) : 545, 592
. : milestone, 569,
iast_HARDCODED_SECRET_DISABLED (515.808 µs) : 493, 539
. : milestone, 516,
iast_INACTIVE (465.478 µs) : 443, 488
. : milestone, 465,
iast_TELEMETRY_OFF (513.408 µs) : 491, 536
. : milestone, 513,
tracing (456.865 µs) : 435, 479
. : milestone, 457,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~b8f44409b6, baseline=1.49.0-SNAPSHOT~b445667208
dateFormat X
axisFormat %s
section baseline
no_agent (15.52 s) : 15520000, 15520000
. : milestone, 15520000,
appsec (14.89 s) : 14890000, 14890000
. : milestone, 14890000,
iast (19.017 s) : 19017000, 19017000
. : milestone, 19017000,
iast_GLOBAL (18.266 s) : 18266000, 18266000
. : milestone, 18266000,
profiling (15.687 s) : 15687000, 15687000
. : milestone, 15687000,
tracing (14.96 s) : 14960000, 14960000
. : milestone, 14960000,
section candidate
no_agent (15.436 s) : 15436000, 15436000
. : milestone, 15436000,
appsec (15.087 s) : 15087000, 15087000
. : milestone, 15087000,
iast (18.972 s) : 18972000, 18972000
. : milestone, 18972000,
iast_GLOBAL (18.071 s) : 18071000, 18071000
. : milestone, 18071000,
profiling (14.773 s) : 14773000, 14773000
. : milestone, 14773000,
tracing (14.888 s) : 14888000, 14888000
. : milestone, 14888000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~b8f44409b6, baseline=1.49.0-SNAPSHOT~b445667208
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (2.379 ms) : 2332, 2426
. : milestone, 2379,
iast (2.162 ms) : 2102, 2221
. : milestone, 2162,
iast_GLOBAL (2.205 ms) : 2145, 2264
. : milestone, 2205,
profiling (2.039 ms) : 1990, 2088
. : milestone, 2039,
tracing (1.997 ms) : 1951, 2043
. : milestone, 1997,
section candidate
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (2.381 ms) : 2334, 2428
. : milestone, 2381,
iast (2.163 ms) : 2103, 2222
. : milestone, 2163,
iast_GLOBAL (2.203 ms) : 2143, 2263
. : milestone, 2203,
profiling (2.009 ms) : 1962, 2057
. : milestone, 2009,
tracing (1.992 ms) : 1946, 2038
. : milestone, 1992,
|
mcculls
reviewed
May 1, 2025
| @@ -51,7 +51,7 @@ default: | |||
| - echo "NORMALIZED_NODE_TOTAL=$NORMALIZED_NODE_TOTAL , NORMALIZED_NODE_INDEX=$NORMALIZED_NODE_INDEX" | |||
|
|
|||
| .gradle_build: &gradle_build | |||
| image: ghcr.io/datadog/dd-trace-java-docker-build:${JAVA_BUILD_IMAGE_VERSION}-base | |||
| image: ghcr.io/datadog/dd-trace-java-docker-build:v25.04-base | |||
There was a problem hiding this comment.
I see JAVA_BUILD_IMAGE_VERSION in this file has been left as v25.01 - is there a reason the new version is inlined here instead of just updating JAVA_BUILD_IMAGE_VERSION ?
There was a problem hiding this comment.
The GitLab configuration was changed from #8385 and #8448 but the automation was not.
@randomanderson can you make a fix to keep the automation running?
mcculls
reviewed
May 1, 2025
| @@ -130,7 +130,7 @@ spotless: | |||
|
|
|||
| test_published_artifacts: | |||
| extends: .gradle_build | |||
| image: ghcr.io/datadog/dd-trace-java-docker-build:${JAVA_BUILD_IMAGE_VERSION}-7 # Needs Java7 for some tests | |||
| image: ghcr.io/datadog/dd-trace-java-docker-build:v25.04-base | |||
There was a problem hiding this comment.
This changes the image from v25.04-7 to v25.04-base - my understanding is that we still need a JDK 7 build to test the Java version check during bootstrap works as expected and doesn't allow the 1.x tracer to be used with Java 7
| @@ -51,7 +51,7 @@ default: | |||
| - echo "NORMALIZED_NODE_TOTAL=$NORMALIZED_NODE_TOTAL , NORMALIZED_NODE_INDEX=$NORMALIZED_NODE_INDEX" | |||
|
|
|||
| .gradle_build: &gradle_build | |||
| image: ghcr.io/datadog/dd-trace-java-docker-build:${JAVA_BUILD_IMAGE_VERSION}-base | |||
| image: ghcr.io/datadog/dd-trace-java-docker-build:v25.04-base | |||
There was a problem hiding this comment.
The GitLab configuration was changed from #8385 and #8448 but the automation was not.
@randomanderson can you make a fix to keep the automation running?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Docker build image to v25.04.