Clean up DSM context injection #8776

PerfectSlayer · 2025-05-07T05:42:22Z

What Does This Do

WIP: Check if I can simplify instrumentation where DSM context creation can be done without any other contextual information than the current span.

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

pr-commenter · 2025-05-07T06:33:47Z

Benchmarks

Startup

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-05-07T13:27:41	2025-05-07T13:35:27
git_branch	master	bbujon/context-propagation-dsm
git_commit_date	1746623495	1746622998
git_commit_sha	`6c8da4d`	`5f1247d`
release_version	1.50.0-SNAPSHOT~6c8da4d60a	1.50.0-SNAPSHOT~5f1247d866
start_time	2025-05-07T13:27:27	2025-05-07T13:35:13

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1746625326	1746625326
ci_job_id	927833083	927833083
ci_pipeline_id	64392103	64392103
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-brbdd7pm-project-304-concurrent-0-fuundgii 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-brbdd7pm-project-304-concurrent-0-fuundgii 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 18 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:petclinic:profiling	better [-110.756µs; -59.111µs] or [-6.943%; -3.706%]	unstable [-360.909op/s; +800.470op/s] or [-12.632%; +28.016%]	1.510ms	3076.923op/s	1.595ms	2857.143op/s

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~5f1247d866, baseline=1.50.0-SNAPSHOT~6c8da4d60a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.356 ms) : 1337, 1374
.   : milestone, 1356,
appsec (1.743 ms) : 1720, 1766
.   : milestone, 1743,
appsec_no_iast (1.733 ms) : 1710, 1756
.   : milestone, 1733,
code_origins (1.676 ms) : 1649, 1703
.   : milestone, 1676,
iast (1.516 ms) : 1492, 1540
.   : milestone, 1516,
profiling (1.595 ms) : 1571, 1620
.   : milestone, 1595,
tracing (1.495 ms) : 1469, 1520
.   : milestone, 1495,
section candidate
no_agent (1.356 ms) : 1335, 1377
.   : milestone, 1356,
appsec (1.738 ms) : 1714, 1762
.   : milestone, 1738,
appsec_no_iast (1.738 ms) : 1714, 1762
.   : milestone, 1738,
code_origins (1.682 ms) : 1655, 1710
.   : milestone, 1682,
iast (1.532 ms) : 1508, 1556
.   : milestone, 1532,
profiling (1.51 ms) : 1487, 1534
.   : milestone, 1510,
tracing (1.502 ms) : 1477, 1526
.   : milestone, 1502,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.356 ms [1.337 ms, 1.374 ms]	-
appsec	1.743 ms [1.72 ms, 1.766 ms]	387.701 µs (28.6%)
appsec_no_iast	1.733 ms [1.71 ms, 1.756 ms]	377.034 µs (27.8%)
code_origins	1.676 ms [1.649 ms, 1.703 ms]	320.304 µs (23.6%)
iast	1.516 ms [1.492 ms, 1.54 ms]	160.205 µs (11.8%)
profiling	1.595 ms [1.571 ms, 1.62 ms]	239.599 µs (17.7%)
tracing	1.495 ms [1.469 ms, 1.52 ms]	139.035 µs (10.3%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.356 ms [1.335 ms, 1.377 ms]	-
appsec	1.738 ms [1.714 ms, 1.762 ms]	381.646 µs (28.1%)
appsec_no_iast	1.738 ms [1.714 ms, 1.762 ms]	382.008 µs (28.2%)
code_origins	1.682 ms [1.655 ms, 1.71 ms]	326.034 µs (24.0%)
iast	1.532 ms [1.508 ms, 1.556 ms]	175.554 µs (12.9%)
profiling	1.51 ms [1.487 ms, 1.534 ms]	154.059 µs (11.4%)
tracing	1.502 ms [1.477 ms, 1.526 ms]	145.5 µs (10.7%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~5f1247d866, baseline=1.50.0-SNAPSHOT~6c8da4d60a
    dateFormat X
    axisFormat %s
section baseline
no_agent (379.131 µs) : 359, 399
.   : milestone, 379,
iast (517.055 µs) : 495, 539
.   : milestone, 517,
iast_FULL (735.389 µs) : 713, 757
.   : milestone, 735,
iast_GLOBAL (583.764 µs) : 560, 607
.   : milestone, 584,
iast_HARDCODED_SECRET_DISABLED (518.016 µs) : 496, 540
.   : milestone, 518,
iast_INACTIVE (468.155 µs) : 446, 491
.   : milestone, 468,
iast_TELEMETRY_OFF (511.079 µs) : 488, 534
.   : milestone, 511,
tracing (464.401 µs) : 442, 487
.   : milestone, 464,
section candidate
no_agent (385.051 µs) : 363, 407
.   : milestone, 385,
iast (523.012 µs) : 500, 546
.   : milestone, 523,
iast_FULL (737.821 µs) : 714, 761
.   : milestone, 738,
iast_GLOBAL (569.097 µs) : 545, 593
.   : milestone, 569,
iast_HARDCODED_SECRET_DISABLED (512.612 µs) : 489, 536
.   : milestone, 513,
iast_INACTIVE (467.76 µs) : 445, 491
.   : milestone, 468,
iast_TELEMETRY_OFF (507.343 µs) : 484, 531
.   : milestone, 507,
tracing (458.802 µs) : 437, 481
.   : milestone, 459,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	379.131 µs [359.307 µs, 398.956 µs]	-
iast	517.055 µs [495.281 µs, 538.83 µs]	137.924 µs (36.4%)
iast_FULL	735.389 µs [713.313 µs, 757.464 µs]	356.257 µs (94.0%)
iast_GLOBAL	583.764 µs [560.391 µs, 607.137 µs]	204.633 µs (54.0%)
iast_HARDCODED_SECRET_DISABLED	518.016 µs [496.09 µs, 539.943 µs]	138.885 µs (36.6%)
iast_INACTIVE	468.155 µs [445.624 µs, 490.685 µs]	89.023 µs (23.5%)
iast_TELEMETRY_OFF	511.079 µs [487.676 µs, 534.482 µs]	131.948 µs (34.8%)
tracing	464.401 µs [442.256 µs, 486.546 µs]	85.27 µs (22.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	385.051 µs [363.086 µs, 407.016 µs]	-
iast	523.012 µs [500.056 µs, 545.968 µs]	137.961 µs (35.8%)
iast_FULL	737.821 µs [714.327 µs, 761.316 µs]	352.771 µs (91.6%)
iast_GLOBAL	569.097 µs [545.069 µs, 593.124 µs]	184.046 µs (47.8%)
iast_HARDCODED_SECRET_DISABLED	512.612 µs [489.486 µs, 535.739 µs]	127.561 µs (33.1%)
iast_INACTIVE	467.76 µs [444.839 µs, 490.682 µs]	82.709 µs (21.5%)
iast_TELEMETRY_OFF	507.343 µs [483.708 µs, 530.978 µs]	122.292 µs (31.8%)
tracing	458.802 µs [436.635 µs, 480.969 µs]	73.751 µs (19.2%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bbujon/context-propagation-dsm
git_commit_date	1746623495	1746622998
git_commit_sha	`6c8da4d`	`5f1247d`
release_version	1.50.0-SNAPSHOT~6c8da4d60a	1.50.0-SNAPSHOT~5f1247d866

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1746625840	1746625840
ci_job_id	927833086	927833086
ci_pipeline_id	64392103	64392103
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-f2hth7be-project-304-concurrent-0-8l9jsnr1 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-f2hth7be-project-304-concurrent-0-8l9jsnr1 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~5f1247d866, baseline=1.50.0-SNAPSHOT~6c8da4d60a
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.862 s) : 14862000, 14862000
.   : milestone, 14862000,
appsec (14.9 s) : 14900000, 14900000
.   : milestone, 14900000,
iast (18.222 s) : 18222000, 18222000
.   : milestone, 18222000,
iast_GLOBAL (18.296 s) : 18296000, 18296000
.   : milestone, 18296000,
profiling (15.06 s) : 15060000, 15060000
.   : milestone, 15060000,
tracing (14.923 s) : 14923000, 14923000
.   : milestone, 14923000,
section candidate
no_agent (15.069 s) : 15069000, 15069000
.   : milestone, 15069000,
appsec (14.974 s) : 14974000, 14974000
.   : milestone, 14974000,
iast (19.231 s) : 19231000, 19231000
.   : milestone, 19231000,
iast_GLOBAL (18.0 s) : 18000000, 18000000
.   : milestone, 18000000,
profiling (14.951 s) : 14951000, 14951000
.   : milestone, 14951000,
tracing (14.763 s) : 14763000, 14763000
.   : milestone, 14763000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.862 s [14.862 s, 14.862 s]	-
appsec	14.9 s [14.9 s, 14.9 s]	38.0 ms (0.3%)
iast	18.222 s [18.222 s, 18.222 s]	3.36 s (22.6%)
iast_GLOBAL	18.296 s [18.296 s, 18.296 s]	3.434 s (23.1%)
profiling	15.06 s [15.06 s, 15.06 s]	198.0 ms (1.3%)
tracing	14.923 s [14.923 s, 14.923 s]	61.0 ms (0.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.069 s [15.069 s, 15.069 s]	-
appsec	14.974 s [14.974 s, 14.974 s]	-95.0 ms (-0.6%)
iast	19.231 s [19.231 s, 19.231 s]	4.162 s (27.6%)
iast_GLOBAL	18.0 s [18.0 s, 18.0 s]	2.931 s (19.5%)
profiling	14.951 s [14.951 s, 14.951 s]	-118.0 ms (-0.8%)
tracing	14.763 s [14.763 s, 14.763 s]	-306.0 ms (-2.0%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~5f1247d866, baseline=1.50.0-SNAPSHOT~6c8da4d60a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.481 ms) : 1470, 1493
.   : milestone, 1481,
appsec (2.396 ms) : 2349, 2444
.   : milestone, 2396,
iast (2.192 ms) : 2132, 2253
.   : milestone, 2192,
iast_GLOBAL (2.226 ms) : 2165, 2287
.   : milestone, 2226,
profiling (2.017 ms) : 1969, 2066
.   : milestone, 2017,
tracing (1.995 ms) : 1948, 2041
.   : milestone, 1995,
section candidate
no_agent (1.482 ms) : 1470, 1493
.   : milestone, 1482,
appsec (2.403 ms) : 2354, 2451
.   : milestone, 2403,
iast (2.181 ms) : 2120, 2241
.   : milestone, 2181,
iast_GLOBAL (2.218 ms) : 2157, 2278
.   : milestone, 2218,
profiling (2.044 ms) : 1995, 2093
.   : milestone, 2044,
tracing (2.015 ms) : 1968, 2062
.   : milestone, 2015,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.481 ms [1.47 ms, 1.493 ms]	-
appsec	2.396 ms [2.349 ms, 2.444 ms]	915.241 µs (61.8%)
iast	2.192 ms [2.132 ms, 2.253 ms]	711.397 µs (48.0%)
iast_GLOBAL	2.226 ms [2.165 ms, 2.287 ms]	744.882 µs (50.3%)
profiling	2.017 ms [1.969 ms, 2.066 ms]	536.377 µs (36.2%)
tracing	1.995 ms [1.948 ms, 2.041 ms]	513.816 µs (34.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.482 ms [1.47 ms, 1.493 ms]	-
appsec	2.403 ms [2.354 ms, 2.451 ms]	920.862 µs (62.1%)
iast	2.181 ms [2.12 ms, 2.241 ms]	698.966 µs (47.2%)
iast_GLOBAL	2.218 ms [2.157 ms, 2.278 ms]	735.822 µs (49.7%)
profiling	2.044 ms [1.995 ms, 2.093 ms]	562.417 µs (38.0%)
tracing	2.015 ms [1.968 ms, 2.062 ms]	532.912 µs (36.0%)

feat(dsm): Clean up context injection

14f01f3

PerfectSlayer added type: enhancement comp: data streams Data Streams Monitoring labels May 7, 2025

feat(dsm): Clean up context injection

b8f9cd9

PerfectSlayer added type: refactoring and removed type: enhancement labels May 7, 2025

feat(dsm): Clean up context injection

5f1247d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean up DSM context injection #8776

Clean up DSM context injection #8776

PerfectSlayer commented May 7, 2025

pr-commenter bot commented May 7, 2025 •

edited

Loading

Clean up DSM context injection #8776

Are you sure you want to change the base?

Clean up DSM context injection #8776

Conversation

PerfectSlayer commented May 7, 2025

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter bot commented May 7, 2025 • edited Loading

Benchmarks

Startup

Load

Parameters

Summary

Dacapo

Parameters

Summary

pr-commenter bot commented May 7, 2025 •

edited

Loading