Double pinyin query

[VictoriousRaptor]

No description provided.

[taooceros]

Maybe it would be better to use ReadOnlySpan as we have quite a few slicing.

[Jack251970]

Done

[taooceros]

@VictoriousRaptor what's the status of this pr?

[VictoriousRaptor]

@VictoriousRaptor what's the status of this pr?

POC. I'm using it daily and so far so good. Since there're many double pinyin mappings we should make it user configurable. Is it acceptable to allow users to edit a json file that defines the mapping?

[taooceros]

well I can't think anything better...maybe I do want this to be plugin-able, but can't think of a good way to design the api.

[Copilot]

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (2)

Flow.Launcher.Infrastructure/UserSettings/Settings.cs:240

• [nitpick] The inline comment 'For developing' is vague. Consider clarifying whether UseDoublePinyin is intended for development only or should be enabled in production.

public bool UseDoublePinyin { get; set; } = true; //For developing

Flow.Launcher.Infrastructure/StringMatcher.cs:71

• The condition has been inverted compared to the original usage of !CanBeTranslated. Please verify that using ShouldTranslate(query) yields the intended translation logic.

if (_alphabet is not null && _alphabet.ShouldTranslate(query))

[Copilot]

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

Flow.Launcher.Infrastructure/PinyinAlphabet.cs:64

• [nitpick] Consider renaming the variable 'dp' to a more descriptive name like 'doublePinyin' for clarity.

string dp = _settings.UseDoublePinyin ? ToDoublePin(resultList[i]) : resultList[i];

[Copilot]

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

Flow.Launcher.Infrastructure/UserSettings/Settings.cs:240

• [nitpick] The inline comment '//For developing' is ambiguous; consider clarifying or removing it if the flag is intended for production use.

public bool UseDoublePinyin { get; set; } = true; //For developing

Flow.Launcher.Infrastructure/StringMatcher.cs:71

• The condition has been changed from negating CanBeTranslated to using ShouldTranslate directly; please verify that the new logic correctly reflects the intended translation behavior.

if (_alphabet is not null && _alphabet.ShouldTranslate(query))

[Copilot]

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

Flow.Launcher.Infrastructure/UserSettings/Settings.cs:240

• [nitpick] Consider updating or removing the 'For developing' comment if this setting is expected to be part of production to avoid confusion.

public bool UseDoublePinyin { get; set; } = true; //For developing

Flow.Launcher.Infrastructure/PinyinAlphabet.cs:165

• When fullPinyin.Length is >= 2 but the first two characters do not match any key in the 'first' dictionary, no conversion is applied, which may result in an empty result. Consider adding a fallback to handle cases when the initial conversion is not matched.

if (fullPinyin.Length >= 2)

[github-actions]

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors	Count
❌ forbidden-pattern	22
⚠️ non-alpha-in-dictionary	19

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it,
  try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.