Skip to content

feat: DIA-2202: Support imported tasks that point to different buckets #7458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 8, 2025

Conversation

hakan458
Copy link
Collaborator

@hakan458 hakan458 commented May 1, 2025

This use case was not supported before:

Import JSON tasks from bucket A
Inside these tasks, there are references to files in bucket B

Now instead of relying on Task.storage (the storage that the Task was imported from), we check all storages in the project, to see if the scheme (e.g. s3) PLUS the bucket name (e.g. my-bucket-b) match the task data's URI. If a matching storage is found, use that to resolve the URI.

@github-actions github-actions bot added the feat label May 1, 2025
Copy link

netlify bot commented May 1, 2025

Deploy Preview for label-studio-storybook ready!

Name Link
🔨 Latest commit 8b09cf9
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-storybook/deploys/681bcc278e1a62000874e6d5
😎 Deploy Preview https://deploy-preview-7458--label-studio-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 1, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 8b09cf9
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/681bcc27716e48000878ffd1

Copy link

netlify bot commented May 1, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 8b09cf9
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/681bcc278a27ca000879c582

@hakan458 hakan458 requested review from matt-bernstein and makseq May 2, 2025 00:16
Copy link

codecov bot commented May 2, 2025

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.07%. Comparing base (dc89b0d) to head (8b09cf9).
Report is 15 commits behind head on develop.

Files with missing lines Patch % Lines
label_studio/io_storages/s3/serializers.py 0.00% 2 Missing ⚠️
label_studio/io_storages/base_models.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7458   +/-   ##
========================================
  Coverage    78.07%   78.07%           
========================================
  Files          197      197           
  Lines        15835    15840    +5     
========================================
+ Hits         12363    12367    +4     
- Misses        3472     3473    +1     
Flag Coverage Δ
pytests 78.07% <78.57%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matt-bernstein
Copy link
Contributor

matt-bernstein commented May 5, 2025

/git merge develop

Workflow run
Successfully merged: create mode 100644 web/tools/extract-antd-no-reset/package.json

@matt-bernstein
Copy link
Contributor

matt-bernstein commented May 5, 2025

/fm sync

Workflow run

@hakan458 hakan458 merged commit b8e917a into develop May 8, 2025
47 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-dia-2202 branch May 8, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants