Matrix Library #448
Open
Matrix Library #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanPhilippeKernel
added
Feature request
Comment on lines
+11
to
+26
| struct RowProxy | ||
| { | ||
| T* row_data; | ||
|
|
||
| T& operator[](size_t col) | ||
| { | ||
| ZENGINE_VALIDATE_ASSERT(col < C, "Column index out of range"); | ||
| return row_data[col]; | ||
| } | ||
|
|
||
| const T& operator[](size_t col) const | ||
| { | ||
| ZENGINE_VALIDATE_ASSERT(col < C, "Column index out of range"); | ||
| return row_data[col]; | ||
| } | ||
| }; |
There was a problem hiding this comment.
I just thought it would be cool if someone just needed a row or column from a matrix 😂, but i can take it out if it is not necessary
Comment on lines
+40
to
+60
| Vec<T, C> getRow(size_t row) const | ||
| { | ||
| ZENGINE_VALIDATE_ASSERT(row < R, "Row index out of range"); | ||
| Vec<T, C> result; | ||
| for (size_t i = 0; i < C; ++i) | ||
| { | ||
| result[i] = this->m_data[row * C + i]; | ||
| } | ||
| return result; | ||
| } | ||
|
|
||
| Vec<T, R> getColumn(size_t col) const | ||
| { | ||
| ZENGINE_VALIDATE_ASSERT(col < C, "Column index out of range"); | ||
| Vec<T, R> result; | ||
| for (size_t i = 0; i < R; ++i) | ||
| { | ||
| result[i] = this->m_data[i * C + col]; | ||
| } | ||
| return result; | ||
| } |
| T identity(); | ||
|
|
||
| template <> | ||
| inline Mat2f identity<Mat2f>() |
There was a problem hiding this comment.
Suggested change
| inline Mat2f identity<Mat2f>() | |
| inline Mat2f Identity<Mat2f>() |
| } | ||
|
|
||
| template <> | ||
| inline Mat3f identity<Mat3f>() |
There was a problem hiding this comment.
Suggested change
| inline Mat3f identity<Mat3f>() | |
| inline Mat3f Identity<Mat3f>() |
| } | ||
|
|
||
| template <> | ||
| inline Mat4f identity<Mat4f>() |
There was a problem hiding this comment.
Suggested change
| inline Mat4f identity<Mat4f>() | |
| inline Mat4f Identity<Mat4f>() |
JeanPhilippeKernel
requested changes
May 7, 2025
| return *this; | ||
| } | ||
|
|
||
| Mat3 inverse() |
There was a problem hiding this comment.
Suggested change
| Mat3 inverse() | |
| Mat3 Inverse() |
Comment on lines
+321
to
+322
| for (size_t i = 0; i < 16; ++i) | ||
| this->m_data[i] = 0; |
There was a problem hiding this comment.
We can simply zero it by memset(....)
JeanPhilippeKernel
requested changes
May 7, 2025
| Matrix<T, R, C> operator+(Matrix<T, R, C>& other) | ||
| { | ||
| Matrix<T, R, C> result{}; | ||
| for (size_t i = 0; i < R; ++i) |
There was a problem hiding this comment.
Make the matrix manipulation Column major
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the support of Mathematics Matrices.
This helps for our effort to move away of GLM library