Skip to content

WIP: replace Images with specific packages #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

timholy
Copy link
Member

@timholy timholy commented Jul 23, 2023

Currently the bottleneck is gaussian_pyramid which is still in
Images.jl

Currently the  bottleneck is `gaussian_pyramid` which is still in
Images.jl
@timholy timholy force-pushed the teh/rm_Images_dep branch from 5ebdae8 to 3356c46 Compare July 23, 2023 11:18
@ashwanirathee
Copy link
Member

ashwanirathee commented Jul 23, 2023

Can we bring pyramid functions here or somewhere more appropriate if needed?That almost empties out algorithms.jl in Images.jl if threshold ones are gone too today and much closer to a meta package than ever.

@timholy
Copy link
Member Author

timholy commented Jul 24, 2023

Pyramids should be a separate package; ImageTracking among likely many others needs them. Though perhaps they could move to ImageBase; it's a pretty fundamental concept in image processing.

@ashwanirathee
Copy link
Member

ashwanirathee commented Jul 30, 2023

Should we make it a separate package then or keep it in ImageBase.jl? I am assuming it doesn't conflict with monorepo work because Images.jl is at top level and ImageBase.jl seems to be separate enough too.

@timholy
Copy link
Member Author

timholy commented Jul 31, 2023

I don't have a strong opinion, but I think since restrict is in ImageBase and we might use restrict in making fast pyramids, I think moving it to ImageBase seems fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants