Skip to content

Fix removal of globals with addrspaces in removeAddrspaces #58322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025

Conversation

gbaraldi
Copy link
Member

@gbaraldi gbaraldi commented May 5, 2025

Found by enzyme

ref @wsmoses

@gbaraldi gbaraldi requested a review from maleadt May 5, 2025 20:21
@gbaraldi gbaraldi added backport 1.10 Change should be backported to the 1.10 release backport 1.11 Change should be backported to release-1.11 backport 1.12 Change should be backported to release-1.12 labels May 5, 2025
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label May 5, 2025
@giordano
Copy link
Contributor

giordano commented May 5, 2025

The newly introduced test in llvmpasses is failing.

@vchuravy vchuravy merged commit 088bb90 into master May 6, 2025
7 checks passed
@vchuravy vchuravy deleted the gb/addrspacefun branch May 6, 2025 09:08
@giordano giordano added compiler:llvm For issues that relate to LLVM and removed merge me PR is reviewed. Merge when all tests are passing labels May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.10 Change should be backported to the 1.10 release backport 1.11 Change should be backported to release-1.11 backport 1.12 Change should be backported to release-1.12 compiler:llvm For issues that relate to LLVM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants