-
Notifications
You must be signed in to change notification settings - Fork 3.5k
DialogHost API revamp #3841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
corvinsz
wants to merge
35
commits into
MaterialDesignInXAML:master
Choose a base branch
from
corvinsz:feat/FullscreenDialog
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
DialogHost API revamp #3841
corvinsz
wants to merge
35
commits into
MaterialDesignInXAML:master
from
corvinsz:feat/FullscreenDialog
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ede38d4.
-adjust the Popups size depending on the "isFullscreenDialog"
…if a full screen dialogis requested
-removed "IsFullscreenDialog" from old "Show" API -added new generic "Show" API which accepts DialogOptions
-added Apply and Revert methods for DialogOptions
…width of the dialog can be restored correctly
-make new Show method non-generic
-added IDialogService interface -modified obsolete message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially I "just" wanted to implement a fullscreen dialog, but I asked myself "why stop here?"
Here are a few thoughts/changes to explain this PR:
Show
methods even more I opted to implement a new class calledDialogOptions
, to have this option-based configuration-styleDialogOptions
has alot ofPrevious<some property>
properties, to keep it as compatible with the oldShow
methods. The way this works is by storing the corresponding property before setting it to something different, then show the dialog, and then revert all the properties to the previously stored value. While the old and new API could be used interchangingly, it is probably a good idea to just stick with one of the two.PART_CloseButton
) to the templateIDialogService
. We already have an abstraction for the Snackbar (ISnackbarMessageQueue
), but not (yet) for the DialogHostThere are 2 things I want to publicly address
Show
methods should we add to theIDialogService
?There are still some ToDos left, but I wanted to share this publicly now so any ideas or recommendations can be incorporated.
If all of this is total nonsense, lmk 😆