Skip to content

[OETHp] [Deploy-004] Deploy VaultValueChecker #2503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shahthepro
Copy link
Collaborator

Deployments

Contract Address
VaultValueChecker 0x26179Ada0f7cb714c11A8190e1f517988c28E759

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.

Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.89%. Comparing base (614cb92) to head (ce96673).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2503   +/-   ##
=======================================
  Coverage   40.89%   40.89%           
=======================================
  Files         101      101           
  Lines        4707     4707           
  Branches     1242     1242           
=======================================
  Hits         1925     1925           
  Misses       2780     2780           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@clement-ux clement-ux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • All deployed contracts are listed in the deploy PR's description
    • VaultValueChecker
  • Deployed contract's verified code (and all dependencies) match the code in master
    • Checked with manual DiffChecker.
  • Contract constructors have correct arguments
    • VaultValueChecker: Vault and OETHp
  • The transactions that interacted with the newly deployed contract match the deploy script.
    • No interaction with deployed contract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants