refactor(ui5-shellbar): extend mobile support for search field #11419
+115
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dobrinyonkov
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the ShellBar component to extend mobile support for the search field and to comply with updated UX specifications. Key changes include updating the search field behavior for mobile devices, adding event handlers for ui5-open/ui5-close/ui5-search events, and introducing new mobile tests.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/fiori/src/ShellBar.ts | Refactored search field properties and event handling to prevent full-width expansion on mobile. |
| packages/fiori/cypress/specs/ShellBar.mobile.cy.tsx | Added new mobile test cases targeting search field state and behavior. |
| packages/fiori/cypress/specs/ShellBar.cy.tsx | Updated test cases to use the new ShellBarSearch component. |
PetyaMarkovaBogdanova
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the ShellBar component's search field behavior to align with UX specifications and support responsive, mobile interactions.
Summary of Changes
Event Handling: Added support for ui5-open, ui5-close, and ui5-search events to dynamically manage
show-search-fieldstate.Testing Enhancements: Added a dedicated mobile test suite (ShellBar.mobile.cy.tsx) and updated existing tests to reflect the component changes.