-
Notifications
You must be signed in to change notification settings - Fork 66
[GEN][ZH] Add endian compat for BIGFileSystems #798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
GeneralsMD/Code/GameEngineDevice/Source/StdDevice/Common/StdBIGFileSystem.cpp
Outdated
Show resolved
Hide resolved
Updated with a more fleshed out endian handling compatability header. |
GeneralsMD/Code/GameEngineDevice/Source/StdDevice/Common/StdBIGFileSystem.cpp
Show resolved
Hide resolved
3a98c64
to
de0f8f7
Compare
Updated, Rebased off main and merge conflict fixed. Tweaked with discussed changes and added endian compat functions to win32Bigfilesystems for generals and zero hour along with stdbigfilesystem. Should be good to go now. |
VC6 does not like the variadic macro. Then we need to do |
Yeah i just noticed this, was just about to change it, should be up in a few seconds. |
8759381
to
615da66
Compare
Now it doesn't like long long, this is taking a long long time. i should really sort my local VC6 build environment lol. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
It would seem that VC6 doesn't like the helper templates EDIT: Figured it out, VC6 doesn't support EDIT2: Nvm wasn't that... |
1aada72
to
8fe7c1e
Compare
This PR is a prerequesit to a PR to unify AsciiString, it adds endian compatibility functions within an endian_compat header.
These are then used in the StdBIGFileSystem as it was previously relying on the ntohl function which was being indirectly provided through the windows header in AsciiString.
This change is necessary to provide cross compat byte swapping functionality.