Skip to content

Fix issues when using nested components in a direct view #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 25, 2024
Merged

Conversation

adamghill
Copy link
Owner

@adamghill adamghill commented Feb 24, 2024

For #662 and CCing @jacksund for visibility.

Fixes a few issues:

  • child components that had force_render=True would always get the parent component's outer element, however direct views are special since they are embedded in a regular template; make sure to send back the actual root element for the parent DOM
  • clean up a logged warning about multiple elements for direct views
  • clean up some docs
  • fix the 'PointerUnicornView' object has no attribute 'component_id' error that happens when refreshing a direct view
  • more doc fixes to make force_render more clear

@adamghill adamghill self-assigned this Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant