fix : Button contentStyle is not correct #4326 #4355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Jayanthidhanabalan, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
lukewalczak
force-pushed
the
main
branch
6 times, most recently
from
1062366 to
1da5d15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Button contentStyle prop was handling icons style when icon is added in the right/left of the Text. When the icon is added on top of the text, iconStyle has to be added for handling the alignment issue.
Related issue
#4326
Test plan
Test Screenshot of the Button with Image on Top Text is shared below,
Button Text : "Image On Top"
I have tested this locally, and it works as expected.