Try register LazyAssemblyLoader to DI in AddInteractiveWebAssemblyCom… #61719
+49
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-blazor
|
This is an alternative solution to #61703. Only one of these should be merged. |
pavelsavara
approved these changes
Apr 28, 2025
|
please consider backport |
…semblyLoader registration
3 tasks
pavelsavara
reviewed
May 7, 2025
| @@ -25,6 +30,15 @@ public static IRazorComponentsBuilder AddInteractiveWebAssemblyComponents(this I | |||
|
|
|||
| builder.Services.TryAddEnumerable(ServiceDescriptor.Singleton<RenderModeEndpointProvider, WebAssemblyEndpointProvider>()); | |||
|
|
|||
| // Try register LazyAssemblyLoader to prevent crashes during prerendering. | |||
| // TODO: Remove this once LazyAssemblyLoader is no longer used. | |||
pavelsavara
reviewed
May 7, 2025
|
|
||
| private static void AssertServerProjectCanUseLazyAssemblyLoader(Project project) | ||
| { | ||
| var assemblyName = "Microsoft.AspNetCore.Components.WebAssembly.dll"; |
There was a problem hiding this comment.
also check that the class is in the dll
pavelsavara
reviewed
May 7, 2025
| // This assert is here to check that the assembly containing LazyAssemblyLoader is actually present in a standard app | ||
| // created from the Blazor Web template. | ||
| // See https://github.com/dotnet/aspnetcore/issues/51966. | ||
| // TODO: Remove this when LazyAssemblyLoader is no longer being used, or the dependency graph changes so reflection is no longer needed. |
|
It turned out the much simpler fix was actually possible (#61822). I erroneously thought it required a project configuration change that we did not want to do (e.g. adding the assembly into the Shared Framework). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
LazyAssemblyLoaderinAddInteractiveWebAssemblyComponents.Description
We want to register
LazyAssemblyLoaderinAddInteractiveWebAssemblyComponentsin order to prevent the confusing situation where a component that injectsLazyAssemblyLoaderworks in the WebAssembly client but crashes during prerendering. (Note that it works when the wasm client takes over becauseWebAssemblyHostBuilder.CreateDefaultregistersLazyAssemblyLoader.)However, this could not be done as is without adding a problematic reference between projects. To avoid this, the implementation uses reflection to try to load the
Microsoft.AspNetCore.Components.WebAssemblyassembly and get the type. If the assembly or the type cannot be found, no error is thrown.