Improving DynamicResource performance (second try)

[batzen]

Second try to improve performance of DynamicResource.

This approach should not cause issues like #10491.

Original issue is still #4468.
Original PR was #5610 with follow up PR #9393 with opt out switch introduced in #9501 and final opt-in switch added in #10516.

Feedback on the approach is very appreciated.

Microsoft Reviewers: Open in CodeFlow

[Copilot]

PR Overview

This PR aims to improve the performance of dynamic resource resolution by refactoring the deferred resource reference handling and optimizing related lookup methods. Key changes include:

• Replacing the DeferredResourceReferenceList with a Dictionary-based weak reference map (_weakDeferredResourceReferencesMap) for deferred resource references.
• Introducing a new private Contains method that returns additional flags to better control deferred resource lookup.
• Refactoring resource reference classes in SystemResources.cs and Baml2006KeyRecord.cs for clarity and performance.

Reviewed Changes

File	Description
ResourceDictionary.cs	Updated deferred reference management with a weak reference map; added new Contains overload and revised methods to use the new infrastructure.
Baml2006KeyRecord.cs	Minor syntax change to standardize type usage.
StyleHelper.cs	Altered the logic order in the deferred resource check to prioritize Freezable types.
SystemResources.cs	Refactored DeferredResourceReference and related classes to use separate _key and _value fields and updated removal logic accordingly.

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/ResourceDictionary.cs:713

• [nitpick] The private Contains method shares its name with the public Contains method, which may lead to confusion. Consider renaming it to better reflect its specialized behavior.

private void Contains(object key, bool mustReturnDeferredResourceReference, out bool contains, out bool containsBamlObjectFactory)

[codecov]

Codecov Report

Attention: Patch coverage is 29.05983% with 83 lines in your changes missing coverage. Please review.

Project coverage is 13.05569%. Comparing base (cac41ae) to head (b266a06).
Report is 21 commits behind head on main.

Additional details and impacted files

@@                 Coverage Diff                 @@
##                main      #10532         +/-   ##
===================================================
+ Coverage   12.66562%   13.05569%   +0.39006%     
===================================================
  Files           3316        3316                 
  Lines         665321      665434        +113     
  Branches       74667       74674          +7     
===================================================
+ Hits           84267       86877       +2610     
+ Misses        578844      576217       -2627     
- Partials        2210        2340        +130     

Flag	Coverage Δ
Debug	13.05569% <29.05983%> (+0.39006%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[harshit7962]

@batzen apologies for the delay in getting started with this. At this state the changes LGTM and we will include this in the next
test run.

[harshit7962]

@batzen The test pass of this is done with, can you please resolve the conflicts? We can take this PR in post that.

[batzen]

Rebased and resolved conflicts.

[batzen]

Not sure why the build is failing.
I consider this a false positive for IDE0100 as the code says "is false".

[harshit7962]

Thank you @batzen for this contribution and thank you @h3xds1nz and @lindexi for your time and suggestions on this.