Remove Critical/Unsecure property/method proxies and CAS-related code

src/Microsoft.DotNet.Wpf/src/PresentationCore/MS/internal/Automation/ElementUtil.cs

@@ -147,7 +147,7 @@ internal static Rect GetScreenRect( IntPtr hwnd, UIElement el )
         // Get element at given point (screen coords)
         internal static Visual GetElementFromPoint( IntPtr hwnd, Visual root, Point pointScreen )
         {
-            HwndSource hwndSource = HwndSource.CriticalFromHwnd(hwnd);
+            HwndSource hwndSource = HwndSource.FromHwnd(hwnd);
 
             if(hwndSource == null)
                 return null;

src/Microsoft.DotNet.Wpf/src/PresentationCore/MS/internal/Interop/TipTsfHelper.cs

@@ -187,7 +187,7 @@ private static bool ShouldShow(DependencyObject focusedObject)
         /// <returns>The HwndSource associated with the Visual</returns>
         private static HwndSource GetHwndSource(DependencyObject focusedObject)
         {
-            return PresentationSource.CriticalFromVisual(focusedObject) as HwndSource;
+            return PresentationSource.FromVisual(focusedObject) as HwndSource;
         }
     }
 }

src/Microsoft.DotNet.Wpf/src/PresentationCore/MS/internal/Shaping/OpenTypeCommon.cs

@@ -660,9 +660,6 @@ private static void CompileFeatureSet(
             }
         }
 
-        /// <SecurityNotes>
-        /// Critical - This method reads into unsafe cluster map. 
-        /// </SecurityNotes>
         private static void GetNextEnabledGlyphRange(
             Feature[]               FeatureSet,     // In: List of features to apply
             int                     featureCount,   // In: Actual nubmer of features in FeatureSet

src/Microsoft.DotNet.Wpf/src/PresentationCore/MS/internal/WpfWebRequestHelper.cs

@@ -22,15 +22,14 @@
 namespace MS.Internal
 {
     /// <summary>
-    /// Helper class for handling all web requests/responses in the framework. Using it ensures consisent handling 
+    /// Helper class for handling all web requests/responses in the framework. Using it ensures consistent handling 
     /// and support for special features: cookies, NTLM authentication, caching, inferring MIME type from filename.
     /// 
     /// Only two methods are mandatory: 
     ///   - CreateRequest. (PackWebRequestFactory.CreateWebRequest is an allowed alternative. It delegates to 
     ///     this CreateRequest for non-pack URIs.)
     ///   - HandleWebResponse. 
-    /// The remaining methods just automate the entire request process, up to the point of getting the response
-    /// stream. Using the SecurityTreatAsSafe ones helps avoid making other code SecurityCritical.
+    /// The remaining methods just automate the entire request process, up to the point of getting the response stream.
     /// 
     /// Related types:
     ///   - BaseUriHelper

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/IO/Packaging/PackageStore.cs

@@ -46,7 +46,6 @@ static PackageStore()
         /// </summary>
         /// <param name="uri">key uri</param>
         /// <returns>Package</returns>
-        /// <permission cref="EnvironmentPermission"></permission>
         /// <remarks>
         /// </remarks>
         public static Package GetPackage(Uri uri)
@@ -71,7 +70,6 @@ public static Package GetPackage(Uri uri)
         /// </summary>
         /// <param name="uri">key uri</param>
         /// <param name="package">package</param>
-        /// <permission cref="EnvironmentPermission"></permission>
         /// <remarks>
         /// If a package with the uri is already in the store,it throws an exception.
         /// The package will not be automatically replaced within the store.
@@ -117,7 +115,6 @@ public static void AddPackage(Uri uri, Package package)
         /// Removes a uri, package pair from the package store.
         /// </summary>
         /// <param name="uri">key uri</param>
-        /// <permission cref="EnvironmentPermission"></permission>
         /// <remarks>
         /// </remarks>
         public static void RemovePackage(Uri uri)

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Automation/Peers/AutomationPeer.cs

@@ -493,12 +493,7 @@ internal AutomationPeer ValidateConnected(AutomationPeer connectedPeer)
         }
 
         /// <summary>
-        /// This is responsible for adding parent info like the parent window handle
-        /// and the parent itself to it's child. This is by definition is a securitycritical operation
-        /// for two reasons
-        /// 1. it's doing an action which is securitycritical
-        /// 2. it can not be treated as safe as it doesn't know whether
-        ///    the peer is actually this objects's parent or not and must be used by methods which has
+        /// This is responsible for adding parent info like the parent window handle and the parent itself to it's child.
         /// </summary>
         /// <param name="peer"></param>
         internal bool TrySetParentInfo(AutomationPeer peer)

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Automation/Peers/UIElement3DAutomationPeer.cs

@@ -172,7 +172,7 @@ private bool ComputeBoundingRectangle(out Rect rect)
         {
             rect = Rect.Empty;
 
-            PresentationSource presentationSource = PresentationSource.CriticalFromVisual(_owner);
+            PresentationSource presentationSource = PresentationSource.FromVisual(_owner);
 
             // If there's no source, the element is not visible, return empty rect
             if(presentationSource == null)

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Automation/Peers/UIElementAutomationPeer.cs

@@ -174,7 +174,7 @@ protected override string GetHelpTextCore()
         ///
         protected override Rect GetBoundingRectangleCore()
         {
-            PresentationSource presentationSource = PresentationSource.CriticalFromVisual(_owner);
+            PresentationSource presentationSource = PresentationSource.FromVisual(_owner);
 
             // If there's no source, the element is not visible, return empty rect
             if(presentationSource == null)
@@ -197,7 +197,7 @@ protected override Rect GetBoundingRectangleCore()
         ///
         internal override Rect GetVisibleBoundingRectCore()
         {
-            PresentationSource presentationSource = PresentationSource.CriticalFromVisual(_owner);
+            PresentationSource presentationSource = PresentationSource.FromVisual(_owner);
 
             // If there's no source, the element is not visible, return empty rect
             if (presentationSource == null)
@@ -491,7 +491,7 @@ protected override Point GetClickablePointCore()
         {
             Point pt = new Point(double.NaN, double.NaN);
 
-            PresentationSource presentationSource = PresentationSource.CriticalFromVisual(_owner);
+            PresentationSource presentationSource = PresentationSource.FromVisual(_owner);
 
             // If there's no source, the element is not visible, return (double.NaN, double.NaN) point
             if(presentationSource == null)

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/DragDrop.cs

@@ -361,10 +361,6 @@ public static void RemoveDropHandler(DependencyObject element, DragEventHandler
         /// <param name="allowedEffects">
         /// The allowed effects that is one of the DragDropEffects values.
         /// </param>
-        /// <remarks>
-        /// Requires UnmanagedCode permission.  
-        /// If caller does not have this permission, the dragdrop will not occur.
-        /// </remarks>
         public static DragDropEffects DoDragDrop(DependencyObject dragSource, object data, DragDropEffects allowedEffects)
         {
             DataObject dataObject;

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Ink/GestureRecognizer.cs

@@ -123,55 +123,27 @@ public ReadOnlyCollection<ApplicationGesture> GetEnabledGestures()
 
         /// <summary>
         /// Performs gesture recognition on the StrokeCollection if a gesture recognizer
-        /// is present and installed on the system.  If not, this method throws an InvalidOperationException.
+        /// is present and installed on the system. If not, this method throws an InvalidOperationException.
         /// To determine if this method will throw an exception, only call this method if
         /// the RecognizerAvailable property returns true.
-        /// 
         /// </summary>
         /// <param name="strokes">The StrokeCollection to perform gesture recognition on</param>
-        /// <returns></returns>
-        /// <remarks>Callers must have UnmanagedCode permission to call this API.</remarks>
         public ReadOnlyCollection<GestureRecognitionResult> Recognize(StrokeCollection strokes)
-        {
-            return RecognizeImpl(strokes);
-        }
-
-        /// <summary>
-        /// Performs gesture recognition on the StrokeCollection if a gesture recognizer
-        /// is present and installed on the system.  If not, this method throws an InvalidOperationException.
-        /// To determine if this method will throw an exception, only call this method if
-        /// the RecognizerAvailable property returns true.
-        /// </summary>
-        /// <param name="strokes">The StrokeCollection to perform gesture recognition on</param>
-        /// <returns></returns>
-        // Built into Core, also used by Framework.
-        internal ReadOnlyCollection<GestureRecognitionResult> CriticalRecognize(StrokeCollection strokes)
-        {
-            return RecognizeImpl(strokes);
-        }
-
-        /// <summary>
-        /// Performs gesture recognition on the StrokeCollection if a gesture recognizer
-        /// is present and installed on the system.
-        /// </summary>
-        /// <param name="strokes">The StrokeCollection to perform gesture recognition on</param>
-        /// <returns></returns>
-        private ReadOnlyCollection<GestureRecognitionResult> RecognizeImpl(StrokeCollection strokes)
         {
             ArgumentNullException.ThrowIfNull(strokes);
+
             if (strokes.Count > 2)
             {
                 throw new ArgumentException(SR.StrokeCollectionCountTooBig, nameof(strokes));
             }
+
             VerifyAccess();
             VerifyDisposed();
             VerifyRecognizerAvailable();
 
             return new ReadOnlyCollection<GestureRecognitionResult>(_nativeRecognizer.Recognize(strokes));
         }
 
-
-
         #endregion Public Methods
 
         //-------------------------------------------------------------------------------

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Input/AccessKeyManager.cs

@@ -1,4 +1,4 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System.Collections;
@@ -450,7 +450,7 @@ private PresentationSource GetSourceForElement(IInputElement element)
 
                 if (containingVisual != null)
                 {
-                    source = PresentationSource.CriticalFromVisual(containingVisual);
+                    source = PresentationSource.FromVisual(containingVisual);
                 }
             }
 
@@ -472,7 +472,7 @@ private PresentationSource CriticalGetActiveSource()
         {
             IntPtr hwnd = MS.Win32.UnsafeNativeMethods.GetActiveWindow();
             if (hwnd != IntPtr.Zero)
-                return HwndSource.CriticalFromHwnd(hwnd);
+                return HwndSource.FromHwnd(hwnd);
 
             return null;
         }

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Input/Command/RoutedCommand.cs

@@ -322,11 +322,13 @@ private bool CanExecuteImpl(object parameter, IInputElement target, bool trusted
                 {
                     RoutedEvent = CommandManager.PreviewCanExecuteEvent
                 };
-                CriticalCanExecuteWrapper(parameter, target, trusted, args);
+
+                CanExecuteWrapper(target, trusted, args);
+
                 if (!args.Handled)
                 {
                     args.RoutedEvent = CommandManager.CanExecuteEvent;
-                    CriticalCanExecuteWrapper(parameter, target, trusted, args);
+                    CanExecuteWrapper(target, trusted, args);
                 }
 
                 continueRouting = args.ContinueRouting;
@@ -339,7 +341,7 @@ private bool CanExecuteImpl(object parameter, IInputElement target, bool trusted
             }
         }
 
-        private void CriticalCanExecuteWrapper(object parameter, IInputElement target, bool trusted, CanExecuteRoutedEventArgs args)
+        private static void CanExecuteWrapper(IInputElement target, bool trusted, CanExecuteRoutedEventArgs args)
         {
             // This cast is ok since we are already testing for UIElement, ContentElement, or UIElement3D
             // both of which derive from DO
@@ -356,8 +358,9 @@ private void CriticalCanExecuteWrapper(object parameter, IInputElement target, b
             else if (targetAsDO is UIElement3D uie3D)
             {
                 uie3D.RaiseEvent(args, trusted);
-            }            
+            }
         }
+
         internal bool ExecuteCore(object parameter, IInputElement target, bool userInitiated)
         {
             if (target == null)

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Input/Cursor.cs

@@ -1,4 +1,4 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System.ComponentModel;
@@ -207,10 +207,6 @@ private void LegacyLoadFromStream(Stream cursorStream)
         {
             //Generate a temporal file based on the memory stream.
 
-            // GetTempFileName requires unrestricted Environment permission
-            // FileIOPermission.Write permission.  However, since we don't
-            // know the path of the file to be created we have to give
-            // unrestricted permission here.
             // GetTempFileName documentation does not mention that it throws
             // any exception. However, if it does, CLR reverts the assert.
 

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Input/FocusManager.cs

@@ -140,7 +140,7 @@ internal static IInputElement GetFocusedElement(DependencyObject element, bool v
             {
                 DependencyObject focusScope = element;
 
-                if (PresentationSource.CriticalFromVisual(focusScope) != PresentationSource.CriticalFromVisual(focusedElement))
+                if (PresentationSource.FromVisual(focusScope) != PresentationSource.FromVisual(focusedElement))
                 {
                     SetFocusedElement(focusScope, null);
                     focusedElement = null;

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Input/InputElement.cs

@@ -1,4 +1,4 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System.Windows.Media;
@@ -267,9 +267,8 @@ internal static Point TranslatePoint(Point pt, DependencyObject from, Dependency
                         // we only know how to do that if both roots are sourced in HwndSources.
                         if(rootFrom != rootTo)
                         {
-                            HwndSource sourceFrom = PresentationSource.CriticalFromVisual(rootFrom) as HwndSource;
-                            HwndSource sourceTo = PresentationSource.CriticalFromVisual(rootTo) as HwndSource;
-
+                            HwndSource sourceFrom = PresentationSource.FromVisual(rootFrom) as HwndSource;
+                            HwndSource sourceTo = PresentationSource.FromVisual(rootTo) as HwndSource;
 
                             if(sourceFrom != null && sourceFrom.Handle != IntPtr.Zero && sourceFrom.CompositionTarget != null &&
                                sourceTo != null && sourceTo.Handle != IntPtr.Zero && sourceTo.CompositionTarget != null)