Skip to content

Don't think skipped ones should be initialized with total number #127944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 9, 2025
Merged

Don't think skipped ones should be initialized with total number #127944

merged 2 commits into from
May 9, 2025

Conversation

smalyshev
Copy link
Contributor

I suspect this might be the reason for failures in CrossClusterQueryWithFiltersIT

@smalyshev
Don't think skipped ones should be initialized with total number.
874de75 
I suspect this might be the reason for failures in CrossClusterQueryWithFiltersIT
@smalyshev smalyshev changed the title Don't think skipped ones should be initialized with total number. Don't think skipped ones should be initialized with total number May 8, 2025
@smalyshev smalyshev requested a review from quux00 May 8, 2025 22:26
@smalyshev smalyshev added :Search Foundations/CCS v9.1.0 v8.19.0 auto-backport Automatically create backport pull requests when merged >non-issue >bug labels May 8, 2025
@smalyshev smalyshev marked this pull request as ready for review May 8, 2025 22:27
@elasticsearchmachine elasticsearchmachine added the Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch label May 8, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

piergm
piergm approved these changes May 9, 2025
View reviewed changes
Copy link
Member

@piergm piergm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@smalyshev smalyshev enabled auto-merge (squash) May 9, 2025 15:31
@smalyshev smalyshev merged commit 5447909 into elastic:main May 9, 2025
16 of 17 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.19 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 127944

@smalyshev
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.19

Questions ?

Please refer to the Backport tool documentation

@smalyshev smalyshev mentioned this pull request May 9, 2025
Merged
smalyshev added a commit to smalyshev/elasticsearch that referenced this pull request May 9, 2025
@smalyshev
Don't think skipped ones should be initialized with total number. (el…
0f41047 
…astic#127944)

I suspect this might be the reason for failures in CrossClusterQueryWithFiltersIT

(cherry picked from commit 5447909)

# Conflicts:
#	muted-tests.yml
elasticsearchmachine pushed a commit that referenced this pull request May 9, 2025
@smalyshev
Don't think skipped ones should be initialized with total number. (#1…
f0c6e09 
…27944) (#127987)

I suspect this might be the reason for failures in CrossClusterQueryWithFiltersIT

(cherry picked from commit 5447909)

# Conflicts:
#	muted-tests.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drempapis drempapis drempapis approved these changes

@piergm piergm piergm approved these changes

@quux00 quux00 Awaiting requested review from quux00

Assignees
No one assigned
Labels
auto-backport Automatically create backport pull requests when merged backport pending >bug >non-issue :Search Foundations/CCS Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v8.19.0 v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smalyshev @elasticsearchmachine @drempapis @piergm