Skip to content

chore: update all non-example defmt dependencies #4162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented May 3, 2025

No description provided.

@jamesmunns
Copy link
Contributor

@nyurik this looks interesting, but CI is failing. It's possible that there are some you missed, or some of the the 0.3.x deps need to be updated to the one that got semver-tricked into 1.0:

thread 'main' panicked at src/bin/cargo-batch.rs:136:85:
called `Result::unwrap()` on an `Err` value: failed to select a version for `defmt`.
    ... required by package `embassy-executor v0.7.0 (/ci/code/embassy-executor)`
    ... which satisfies path dependency `embassy-executor` (locked to 0.7.0) of package `embassy-basic-example v0.1.0 (/ci/code/docs/examples/basic)`
versions that meet the requirements `^1.0.1` are: 1.0.1

the package `defmt` links to the native library `defmt`, but it conflicts with a previous package which links to `defmt` as well:
package `defmt v0.3.10`
    ... which satisfies dependency `defmt = "^0.3"` (locked to 0.3.10) of package `embassy-basic-example v0.1.0 (/ci/code/docs/examples/basic)`
Only one package in the dependency graph may specify the same links value. This helps ensure that only one copy of a native library is linked in the final binary. Try to adjust your dependencies so that only one package uses the `links = "defmt"` value. For more information, see https://doc.rust-lang.org/cargo/reference/resolver.html#links.

failed to select a version for `defmt` which could resolve this conflict
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
run failed: exited with code 101

So embassy-basic-example needs to be updated somehow?

@Dirbaio
Copy link
Member

Dirbaio commented May 3, 2025

Yeah this is because CI caches lockfiles.

I think updating defmt everywhere to 1.0 should fix it.

I updated all other panic-probe, defmt, and defmt-rtt to the latest, and made cargo.toml declarations to use the same pattern.  Also, a few minor spacing changes for consistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants