Fix UnboundLocalError in GUI on_populate_tree_lists method leading to unresponsive left panel #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a safeguard to skip items in `user_lists` that do not match expected types (`UserPlaylist`, `Playlist`, or `Mix`). - Ensured `twi_child` is only accessed when properly initialized. - This prevents crashes during GUI interaction when unexpected data is encountered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes a bug in the
on_populate_tree_listsmethod where the left panel could become unresponsive when processing unexpected item types in user lists.Details
The issue occurred when an item in the
user_listsdid not match the expected types (UserPlaylist,Playlist, orMix). This left thetwi_childvariable uninitialized, causing the following error:While the application itself did not crash, the left panel became unresponsive.
Fix
Added an
else: continueclause to ensure unsupported items are skipped, preventing thetwi_childvariable from being accessed without initialization.Testing
Tested with various user list combinations, including unsupported item types, to confirm that the left panel now loads correctly without issues.
If you have additional test cases or encounter related issues, feel free to provide feedback. Thanks for reviewing this PR!