dataconnect: include relevant logcat snippets in github actions logs when androidTest tests fail #6902

dconeybe · 2025-04-22T20:36:18Z

With this PR, the GitHub Actions workflow output includes relevant snippets from the logcat logs for failed tests. Before this PR, one would need to manually download the logcat log file from the workflow artifacts and grok it themselves.

The new github actions log output looks something like this:

+ python firebase-dataconnect/ci/logcat_error_report.py --logcat-file=logcat.log
Extracting test failures from logcat.log
FAILED TEST: forcedFailureRevertMeBeforeMerging(com.google.firebase.dataconnect.AnyScalarIntegrationTest)
Found results for 423 tests:422 passed, 1 failed
Failure 1/1: forcedFailureRevertMeBeforeMerging(com.google.firebase.dataconnect.AnyScalarIntegrationTest):
04-22 20:[42](https://github.com/firebase/firebase-android-sdk/actions/runs/14604151406/job/40969205145?pr=6902#step:22:43):12.156  2453  2474 I TestRunner: started: forcedFailureRevertMeBeforeMerging(com.google.firebase.dataconnect.AnyScalarIntegrationTest)
04-22 20:42:12.157  2453  2477 D FirebaseDataConnect: [16.0.1] LogLevelChange[id=lgrnhsm8663jy] Log level changed to DEBUG (was WARN)
04-22 20:42:12.158  2453  2474 E TestRunner: failed: forcedFailureRevertMeBeforeMerging(com.google.firebase.dataconnect.AnyScalarIntegrationTest)
04-22 20:42:12.158  2[45](https://github.com/firebase/firebase-android-sdk/actions/runs/14604151406/job/40969205145?pr=6902#step:22:46)3  2474 E TestRunner: ----- begin exception -----
04-22 20:42:12.158  2453  2477 D FirebaseDataConnect: [16.0.1] LogLevelChange[id=lgrnhsm8663jy] Log level changed to WARN (was DEBUG)
04-22 20:42:12.159  2453  2[47](https://github.com/firebase/firebase-android-sdk/actions/runs/14604151406/job/40969205145?pr=6902#step:22:48)4 E TestRunner: java.lang.Exception: vzmht3nbgr forced error!
04-22 20:42:12.159  2453  2474 E TestRunner: 	at com.google.firebase.dataconnect.AnyScalarIntegrationTest.forcedFailureRevertMeBeforeMerging(AnyScalarIntegrationTest.kt:72)
04-22 20:42:12.159  2453  2474 E TestRunner: 	at java.lang.reflect.Method.invoke(Native Method)
04-22 20:42:12.159  2453  2474 E TestRunner: 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
04-22 20:42:12.159  2453  2474 E TestRunner: 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)

See https://github.com/firebase/firebase-android-sdk/actions/runs/14604151406/job/40969205145?pr=6902

github-actions · 2025-04-22T20:36:27Z

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

github-actions · 2025-04-22T20:36:36Z

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v10.0

github-actions · 2025-04-22T20:51:01Z

Test Results

1 056 files + 1 012 1 056 suites +1 012 35m 45s ⏱️ + 29m 34s
5 974 tests + 5 838 5 952 ✅ + 5 816 22 💤 +22 0 ❌ ±0
12 011 runs +11 719 11 967 ✅ +11 675 44 💤 +44 0 ❌ ±0

Results for commit d6355ae. ± Comparison against base commit 4c4c7c9.

♻️ This comment has been updated with latest results.

…rt.py

…logic" This reverts commit 96d9850.

Copilot

Pull Request Overview

This PR enhances the GitHub Actions workflow to automatically output relevant logcat snippets when Android tests fail. Key changes include:

Updating the GitHub Actions workflow to check for and process logcat.log files.
Adding a new logcat error reporting script (with associated tests) that extracts and formats output from test failures.
Adjusting linting rules and the CI command in the README to align with these new behaviors.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
firebase-dataconnect/ci/pyproject.toml	Updated linting rules to ignore function complexity and branch count issues.
firebase-dataconnect/ci/logcat_error_report_test.py	Added tests for validating regex patterns for logcat extraction.
firebase-dataconnect/ci/logcat_error_report.py	Introduced a new script to extract and output logcat snippets on failed tests.
firebase-dataconnect/ci/README.md	Updated the CI command to include automatic lint fixing before testing.
.github/workflows/dataconnect.yml	Modified the workflow to install Python, handle missing logcat files, and invoke the logcat reporting script.

Comments suppressed due to low confidence (1)

.github/workflows/dataconnect.yml:240

The token 'dsdta43sxk' in the warning message appears arbitrary and may be unclear to other developers; consider replacing it with a more descriptive identifier or removing it altogether.

echo "WARNING dsdta43sxk: logcat log file not found; skipping scanning for test failures" >&2

google-oss-bot · 2025-04-22T21:17:13Z

Size Report ¹

Affected Products

No changes between base commit (4c4c7c9) and merge commit (41fa3d5).

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/nFKIlLxXDp.html

google-oss-bot · 2025-04-22T21:38:01Z

Startup Time Report ¹

The report is too large (122,579 chars) to be displayed on GitHub. Please check this report on GCS.

https://storage.googleapis.com/firebase-sdk-metric-reports/Ip2mhz3km3/index.html

google-oss-bot · 2025-04-22T22:27:09Z

Coverage Report ¹

Affected Products

firebase-database
Overall coverage changed from 50.21% (4c4c7c9) to 50.20% (41fa3d5) by -0.01%.
Filename Base (4c4c7c9) Merge (41fa3d5) Diff
BooleanNode.java 92.31% 100.00% +7.69%
DefaultPersistenceManager.java 75.73% 74.76% -0.97%
ViewProcessor.java 92.10% 91.79% -0.30%
firebase-messaging
Overall coverage changed from 84.13% (4c4c7c9) to 84.10% (41fa3d5) by -0.04%.
Filename Base (4c4c7c9) Merge (41fa3d5) Diff
FirebaseMessaging.java 76.00% 75.60% -0.40%
firebase-sessions
Overall coverage changed from 66.67% (4c4c7c9) to 66.56% (41fa3d5) by -0.11%.
Filename Base (4c4c7c9) Merge (41fa3d5) Diff
RemoteSettings.kt 88.73% 87.32% -1.41%
firebase-storage
Overall coverage changed from 83.92% (4c4c7c9) to 83.96% (41fa3d5) by +0.04%.
Filename Base (4c4c7c9) Merge (41fa3d5) Diff
StreamDownloadTask.java 88.41% 88.89% +0.48%

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/zzyQD24Odq.html

dconeybe added 2 commits April 22, 2025 16:34

logcat_error_report.py added, and dataconnect.yml modified to use it

0c8357c

REVERT ME: forced test failure to verify the github workflow logic

96d9850

dconeybe added no-changelog main-merge-ack api: dataconnect labels Apr 22, 2025

dconeybe self-assigned this Apr 22, 2025

google-oss-bot added the do-not-merge/work-in-progress label Apr 22, 2025

google-oss-bot added the size/L label Apr 22, 2025

logcat_error_report.py: add missing space in log message after ":"

5e89ec0

dconeybe added 2 commits April 22, 2025 16:51

dataconnect.yml: clean up output of step that calls logcat_error_repo…

29a6ad3

…rt.py

Revert "REVERT ME: forced test failure to verify the github workflow …

f1ec66c

…logic" This reverts commit 96d9850.

dconeybe requested a review from Copilot April 22, 2025 20:57

Copilot AI reviewed Apr 22, 2025

View reviewed changes

dconeybe marked this pull request as ready for review April 22, 2025 21:42

google-oss-bot removed the do-not-merge/work-in-progress label Apr 22, 2025

dconeybe requested a review from aashishpatil-g April 22, 2025 21:57

Merge branch 'main' into dconeybe/dataconnect/CiParseErrorsFromLogcat

d6355ae

aashishpatil-g approved these changes May 6, 2025

View reviewed changes

dconeybe merged commit 88f50d5 into main May 6, 2025
433 of 434 checks passed

dconeybe deleted the dconeybe/dataconnect/CiParseErrorsFromLogcat branch May 6, 2025 22:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dataconnect: include relevant logcat snippets in github actions logs when androidTest tests fail #6902

dataconnect: include relevant logcat snippets in github actions logs when androidTest tests fail #6902

dconeybe commented Apr 22, 2025 •

edited

Loading

github-actions bot commented Apr 22, 2025 •

edited

Loading

github-actions bot commented Apr 22, 2025

github-actions bot commented Apr 22, 2025 •

edited

Loading

Copilot AI left a comment

google-oss-bot commented Apr 22, 2025 •

edited

Loading

google-oss-bot commented Apr 22, 2025 •

edited

Loading

google-oss-bot commented Apr 22, 2025 •

edited

Loading

`firebase-database`

`firebase-messaging`

`firebase-sessions`

`firebase-storage`

dataconnect: include relevant logcat snippets in github actions logs when androidTest tests fail #6902

dataconnect: include relevant logcat snippets in github actions logs when androidTest tests fail #6902

Conversation

dconeybe commented Apr 22, 2025 • edited Loading

github-actions bot commented Apr 22, 2025 • edited Loading

📝 PRs merging into main branch

github-actions bot commented Apr 22, 2025

Vertex AI Mock Responses Check ⚠️

github-actions bot commented Apr 22, 2025 • edited Loading

Test Results

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

google-oss-bot commented Apr 22, 2025 • edited Loading

Size Report 1

Affected Products

Test Logs

google-oss-bot commented Apr 22, 2025 • edited Loading

Startup Time Report 1

google-oss-bot commented Apr 22, 2025 • edited Loading

Coverage Report 1

Affected Products

firebase-database

firebase-messaging

firebase-sessions

firebase-storage

Test Logs

dconeybe commented Apr 22, 2025 •

edited

Loading

github-actions bot commented Apr 22, 2025 •

edited

Loading

github-actions bot commented Apr 22, 2025 •

edited

Loading

google-oss-bot commented Apr 22, 2025 •

edited

Loading

Size Report ¹

google-oss-bot commented Apr 22, 2025 •

edited

Loading

Startup Time Report ¹

google-oss-bot commented Apr 22, 2025 •

edited

Loading

Coverage Report ¹

`firebase-database`

`firebase-messaging`

`firebase-sessions`

`firebase-storage`