Skip to content

fix: limit text overflows right side panel #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025
Merged

Conversation

RohitR311
Copy link
Collaborator

@RohitR311 RohitR311 commented Apr 30, 2025

What this PR does?

Fixes the text overflow for the right side panel limit window.

Closes: #576

image

Summary by CodeRabbit

  • Style
    • Updated the appearance of the form label and limit options in the right side panel for improved consistency and responsiveness.

@RohitR311 RohitR311 added Type: Bug Something isn't working Scope: UI/UX Issues/PRs related to UI/UX labels Apr 30, 2025
@RohitR311 RohitR311 requested a review from amhsirak April 30, 2025 21:16
Copy link

coderabbitai bot commented Apr 30, 2025

Walkthrough

The update modifies the styling of the limit options section in the right side panel component. Specifically, it replaces an HTML <h4> label with a Material-UI <Typography> component for improved styling control and changes the width of the RadioGroup from a fixed value to full width. No logic, event handling, or control flow is affected by these changes.

Changes

File(s) Change Summary
src/components/recorder/RightSidePanel.tsx Replaced <h4> with <Typography> for the form label; updated RadioGroup width to 100%.

Assessment against linked issues

Objective Addressed Explanation
Prevent custom limit text from overflowing right side panel (#576)

Suggested reviewers

  • amhsirak

Poem

In the panel on the right,
Where text once put up a fight,
Now it fits, neat and wide,
Styled with care, no need to hide.
A rabbit hops, quite content—
Overflow woes now circumvent! 🐇

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
src/components/recorder/RightSidePanel.tsx (2)

623-631: Enhance semantics & simplify styling
You’ve replaced the old <h4> with a <Typography> inside <FormLabel>, which fixes overflow. For stronger semantics and accessibility, consider:

  1. Wrapping the radios in a real fieldset/legend by setting
    <FormControl component="fieldset">
      <FormLabel component="legend" ></FormLabel></FormControl>
  2. Styling the <FormLabel> directly with sx instead of nesting <Typography>.
  3. Swapping the non-standard wordBreak: 'break-word' for the more widely supported overflowWrap: 'break-word'.

Example diff:

- <FormControl>
-   <FormLabel>
-     <Typography variant="h6" sx={{
-       fontSize: '16px',
-       fontWeight: 'bold',
-       mb: 1,
-       whiteSpace: 'normal',
-       wordBreak: 'break-word'
-     }}>
-       {t('right_panel.limit.title')}
-     </Typography>
-   </FormLabel>
+ <FormControl component="fieldset" sx={{ width: '100%' }}>
+   <FormLabel component="legend" sx={{
+     typography: 'h6',
+     fontWeight: 'bold',
+     mb: 1,
+     whiteSpace: 'normal',
+     overflowWrap: 'break-word'
+   }}>
+     {t('right_panel.limit.title')}
+   </FormLabel>

638-642: Ensure width actually constrains the group
You’ve set width: '100%' on the RadioGroup, but if its parent <FormControl> or wrapping <Box> are still auto-sized, it won’t have any effect. It’s more robust to move the width rule up to the <FormControl> (or its container), for example:

- <FormControl>
+ <FormControl component="fieldset" sx={{ width: '100%' }}>
   <FormLabel …>…</FormLabel>
   <RadioGroup
     value={limitType}
     onChange={…}
-    sx={{
-      display: 'flex',
-      flexDirection: 'column',
-      width: '100%',
-    }}
+    sx={{ display: 'flex', flexDirection: 'column' }}
   >

This ensures the entire group fills its parent and avoids any overflow.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 60176fe and 9be9057.

📒 Files selected for processing (1)
  • src/components/recorder/RightSidePanel.tsx (1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
src/components/recorder/RightSidePanel.tsx (1)
src/context/browserActions.tsx (1)
  • LimitType (7-7)

@amhsirak amhsirak merged commit 323a610 into develop May 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: UI/UX Issues/PRs related to UI/UX Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Custom limit text overflows right side panel
2 participants