Skip to content

fix(widget-builder): Only allow count(spans) in sort #91065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025

Conversation

narsaynorath
Copy link
Member

Take 2 because the last one didn't account for the sort by in tables and would try to calculate the timeseries sort options for a dataset without timeseries support (i.e. issues)

@narsaynorath narsaynorath requested review from a team as code owners May 6, 2025 19:31
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 6, 2025
Copy link

codecov bot commented May 6, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
10278 1 10277 9
View the top 1 failed test(s) by shortest run time
EventSearch handles basic inputs for tags
Stack Traces | 5.1s run time
Error: thrown: "Exceeded timeout of 5000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
    at .../issueDetails/streamline/eventSearch.spec.tsx:51:3
    at _dispatchDescribe (.../jest-circus/build/index.js:91:26)
    at describe (.../jest-circus/build/index.js:55:5)
    at Object.<anonymous> (.../issueDetails/streamline/eventSearch.spec.tsx:15:1)
    at Runtime._execModule (.../jest-runtime/build/index.js:1439:24)
    at Runtime._loadModule (.../jest-runtime/build/index.js:1022:12)
    at Runtime.requireModule (.../jest-runtime/build/index.js:882:12)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:77:13)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@narsaynorath narsaynorath merged commit 5e179d5 into master May 6, 2025
42 checks passed
@narsaynorath narsaynorath deleted the nar/fix/widget-builder-only-allow-count-spans branch May 6, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants