Fix contributors related page may leak resources #34016
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
lunny
force-pushed
the
lunny/fix_failed_contributors
branch
from
76affd2 to
1dbcf89
Compare
GiteaBot
added
lgtm/blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when users visited the contributors-related page and closed it immediately, some subprocesses were never properly cleaned up. If the user refreshed the page multiple times, this could lead to a buildup of orphaned subprocesses running in the background.
This PR refactors the original design. The server no longer relies on timeouts to manage subprocesses. Instead, background subprocesses are now properly released when the page is closed or reloaded.