Make ndk version configurable as a command-like argument. #1779
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivorforce
added
cherrypick:4.2
cherrypick:4.3
cherrypick:4.4
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my project, I need to bump ndk to a newer version to be able to use C++20.
It would be possible to bump it here, but that would possibly break users' CI (on update), and wouldn't be future proof either.
I think it's appropriate to just make it configurable, since I don't think it needs to be in sync with godotengine master.
Edit: I have tested this with my own GDExtension, seems to build fine! I haven't tested it will run, but given that godot itself has been ndk version 27 now, I don't think it's required to use the same version as it does, so I don't think there should be hidden caveats.