-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Support Tracing for Interservice gRPC calls #1394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Tracing for Interservice gRPC calls #1394
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Readme can be update either to refer the docs at gofr.dev/docs such that user can understand how these files are created.
-
Can we structure the examples in a better way -
For example, for interservice http communication we dont have 2 examples.
one way could be to have grpc and inside that we have two separate directories for a client and a server
mdsf is a tool that formats Markdown files with fenced code blocks. https://github.com/hougesen/mdsf It is used to ensure that all code blocks are formatted in a consistent way.
There are no such a thing as an indented fenced code block in Markdown. This commit fixes the indentation of fenced code blocks. Files are then formatted with mdsf tool.
mdsf is a tool that formats Markdown files with fenced code blocks. https://github.com/hougesen/mdsf It is used to ensure that all code blocks are formatted in a consistent way.
…interservice-grpc-tracing merge
As there are multiple changes in files ... that are not related to the PR itself. I will be closing the PR and creating a new one. Link to the new PR : #1408 |
Description:
Checklist:
goimport
andgolangci-lint
.Thank you for your contribution!