Optimize the SSE delimiting of streamed messages #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gopkarthik
approved these changes
May 7, 2025
| @@ -69,12 +69,12 @@ struct JsonResponseTranslateOptions { | |||
| // If set to true, newline "\n" is used to separate streaming messages. | |||
| // If set to false, all streaming messages are treated as a JSON array and | |||
| // separated by comma. | |||
| bool stream_newline_delimited; | |||
| bool stream_newline_delimited = false; | |||
There was a problem hiding this comment.
Setting a default could affect existing users. Do we need to set a default here?
Can you also add a comment that setting stream_sse_style_delimited will override/ignore this?
There was a problem hiding this comment.
I've added that to the comment on stream_sse_style_delimited.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gopkarthik, numanelahi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR