-
Notifications
You must be signed in to change notification settings - Fork 4.5k
xds: remove temporary environment variable for least request #8248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8248 +/- ##
==========================================
- Coverage 82.15% 82.13% -0.03%
==========================================
Files 412 412
Lines 40477 40474 -3
==========================================
- Hits 33253 33242 -11
- Misses 5864 5866 +2
- Partials 1360 1366 +6
🚀 New features to boost your workflow:
|
As discussed I'll keep this PR for later and work on a change that just flips the environment variable default to |
@dfawley is it sufficient for one minor version (1.72) to have the flag defaulted to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this particular case, I think it's fine. I am not really concerned that registering this LB policy by default is going to cause problems. For other things that might be more risky, because we know our users don't always upgrade in a timely fashion, I think it's better to wait at least 2-3 releases before removing the flag.
@atollena can you please take a look at the merge conflicts? Thanks! |
@arjan-bal please do a second review & approve. |
Fixes #8228.
RELEASE NOTES: Remove the
GRPC_EXPERIMENTAL_ENABLE_LEAST_REQUEST
environment variable that allows disabling the least request balancer with xDS. Least request was made available by default with xDS in v1.72.0.