Skip to content

Cardinality violations in Client streaming RPC. #8278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Cardinality violations in Client streaming RPC. #8278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions stream.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,6 +542,8 @@ type clientStream struct {

sentLast bool // sent an end stream

recvMsg bool // received msg from server
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Boolean field names should be like questions with yes/no answers, example "didReceiveFirstMessage".


methodConfig *MethodConfig

ctx context.Context // the application's context, wrapped by stats/tracing
Expand Down Expand Up @@ -1134,11 +1136,17 @@ func (a *csAttempt) recvMsg(m any, payInfo *payloadInfo) (err error) {
if statusErr := a.transportStream.Status().Err(); statusErr != nil {
return statusErr
}
if cs.desc.ClientStreams && !cs.desc.ServerStreams && !cs.recvMsg{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we leave out cs.desc.ClientStreams from this check? I would assume that the server needs to send a message for unary RPCs also. Are unary RPCs handled by this code path? If yes, we should add a test for unary RPCs also.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vet checks is failing, probably because of the missing space before {. Can you please fix the vet issues?

return status.Errorf(codes.Internal, "client streaming cardinality violation")
}
return io.EOF // indicates successful end of stream.
}

return toRPCErr(err)
}
if cs.desc.ClientStreams {
cs.recvMsg = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we set this boolean without the check? Otherwise we would need to document the variable in a way to make it obvious that this is set only for client streaming RPCs. Even then users may accidentally use it for other types of RPCs.

}
if a.trInfo != nil {
a.mu.Lock()
if a.trInfo.tr != nil {
Expand Down
3 changes: 0 additions & 3 deletions test/end2end_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3588,9 +3588,6 @@ func testClientStreamingError(t *testing.T, e env) {
// Tests that a client receives a cardinality violation error for client-streaming
// RPCs if the server doesn't send a message before returning status OK.
func (s) TestClientStreamingCardinalityViolation_ServerHandlerMissingSendAndClose(t *testing.T) {
// TODO : https://github.com/grpc/grpc-go/issues/8119 - remove `t.Skip()`
// after this is fixed.
t.Skip()
ss := &stubserver.StubServer{
StreamingInputCallF: func(_ testgrpc.TestService_StreamingInputCallServer) error {
// Returning status OK without sending a response message.This is a
Expand Down
Loading