cmd/protoc-gen-go-grpc: Add flag to use separate service package #8280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8280 +/- ##
==========================================
+ Coverage 82.13% 82.19% +0.06%
==========================================
Files 417 417
Lines 41385 41385
==========================================
+ Hits 33991 34018 +27
+ Misses 5961 5941 -20
+ Partials 1433 1426 -7 🚀 New features to boost your workflow:
|
arjan-bal
reviewed
Apr 30, 2025
arjan-bal
changed the title
dfawley
reviewed
Apr 30, 2025
| @@ -58,6 +61,7 @@ func main() { | |||
| var flags flag.FlagSet | |||
| requireUnimplemented = flags.Bool("require_unimplemented_servers", true, "set to false to match legacy behavior") | |||
| useGenericStreams = flags.Bool("use_generic_streams_experimental", true, "set to true to use generic types for streaming client and server objects; this flag is EXPERIMENTAL and may be changed or removed in a future release") | |||
| useSeparateServicePackage = flags.Bool("use_separate_service_package", false, "set to true to use separate service package, service package will import protobuf package") | |||
There was a problem hiding this comment.
How about something like: name this output_package and make it a string? Then the import path could be file.GoImportPath with everything after the last / stripped and replaced by what's specified here? That would allow more flexibility for how the code is generated.
There was a problem hiding this comment.
The import path becomes unnecessary after the file is generated.
qianlongzt
force-pushed
the
feat-use-separate-service-package
branch
from
62d01f8 to
a79e9fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8233
Release notes for cmd/protoc-gen-go-grpc:
use_separate_service_packagehas been added to support generating service and message code in separate packages. When this flag is set totrue, the service code will import the message package and refer to message symbols using package-qualified names. Since both the service and message code still share the same package names, users must either use the--go-grpc_outflag to place the service code in a different directory or manually move it.RELEASE NOTES: none